Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1005413002: HTMLViewer: Log JS messages to console (Closed)

Created:
5 years, 9 months ago by DaveMoore
Modified:
5 years, 9 months ago
Reviewers:
jamesr, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTMLViewer: Log JS messages to console BUG= Committed: https://crrev.com/12cf57ce97cf1a89a7d0e017389b72cd81807785 Cr-Commit-Position: refs/heads/master@{#320786}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M mojo/services/html_viewer/html_document.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
DaveMoore
5 years, 9 months ago (2015-03-15 22:53:19 UTC) #2
sky
+jamesr as I'm not an owner here.
5 years, 9 months ago (2015-03-16 15:40:43 UTC) #4
sky
LGTM
5 years, 9 months ago (2015-03-16 15:40:47 UTC) #5
jamesr
lgtm
5 years, 9 months ago (2015-03-16 19:25:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005413002/1
5 years, 9 months ago (2015-03-16 20:09:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-16 20:37:46 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 20:38:27 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/12cf57ce97cf1a89a7d0e017389b72cd81807785
Cr-Commit-Position: refs/heads/master@{#320786}

Powered by Google App Engine
This is Rietveld 408576698