Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1005393004: Handlify Map::SetPrototype() (Closed)

Created:
5 years, 9 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Handlify Map::SetPrototype() Committed: https://crrev.com/c1f28b6c103c828af3e640ce9cb7e6afb4fbc80f Cr-Commit-Position: refs/heads/master@{#27745}

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : rebased to patch set 4 of 1033653002 #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -43 lines) Patch
M src/bootstrapper.cc View 1 2 3 9 chunks +22 lines, -16 lines 0 comments Download
M src/factory.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +7 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 5 chunks +21 lines, -16 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-heap.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jakob Kummerow
PTAL. This is split out from https://codereview.chromium.org/908213002/.
5 years, 9 months ago (2015-03-24 12:08:47 UTC) #2
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-26 15:40:55 UTC) #3
caitp (gmail)
On 2015/03/26 15:40:55, Toon Verwaest wrote: > lgtm needs a rebase after 1027283004 --- was ...
5 years, 8 months ago (2015-03-26 17:26:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005393004/60001
5 years, 8 months ago (2015-04-10 11:36:24 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-10 12:13:23 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 12:13:38 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/c1f28b6c103c828af3e640ce9cb7e6afb4fbc80f
Cr-Commit-Position: refs/heads/master@{#27745}

Powered by Google App Engine
This is Rietveld 408576698