chrome/browser/download/download_commands.cc - Issue 1005393003: [Download Notification] Use NotificationUIManager instead of MessageCenter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_commands.cc

Issue 1005393003: [Download Notification] Use NotificationUIManager instead of MessageCenter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed the comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/download/notification/download_notification_item.h » ('j') | chrome/browser/download/notification/download_notification_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/download/download_commands.cc

diff --git a/chrome/browser/download/download_commands.cc b/chrome/browser/download/download_commands.cc

index 15b6d6bac73385ceffd2be5711d07b9900086de9..97784977e39b20f3f88b82ed0210bc26bebca988 100644

--- a/chrome/browser/download/download_commands.cc

+++ b/chrome/browser/download/download_commands.cc

@@ -42,10 +42,14 @@ int DownloadCommands::GetCommandIconId(Command command) {

return IDR_DOWNLOAD_NOTIFICATION_MENU_DOWNLOAD;

case DISCARD:

return IDR_DOWNLOAD_NOTIFICATION_MENU_DELETE;

+ case CANCEL:

+ // TODO(yoshiki): This is a temporary image for Download Notification

+ // feature behind the flag. We have to replace the image with proper one

+ // before the feature launch. http://crbug.com/468559

+ return IDR_DOWNLOAD_NOTIFICATION_MENU_DELETE;

case OPEN_WHEN_COMPLETE:

case ALWAYS_OPEN_TYPE:

case PLATFORM_OPEN:

- case CANCEL:

case LEARN_MORE_SCANNING:

case LEARN_MORE_INTERRUPTED:

return -1;