Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3756)

Unified Diff: chrome/browser/download/download_commands.cc

Issue 1005393003: [Download Notification] Use NotificationUIManager instead of MessageCenter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused code Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_commands.cc
diff --git a/chrome/browser/download/download_commands.cc b/chrome/browser/download/download_commands.cc
index 15b6d6bac73385ceffd2be5711d07b9900086de9..f4ca401501fa888de15dbc2d6b3187d47de25c41 100644
--- a/chrome/browser/download/download_commands.cc
+++ b/chrome/browser/download/download_commands.cc
@@ -42,10 +42,12 @@ int DownloadCommands::GetCommandIconId(Command command) {
return IDR_DOWNLOAD_NOTIFICATION_MENU_DOWNLOAD;
case DISCARD:
return IDR_DOWNLOAD_NOTIFICATION_MENU_DELETE;
+ case CANCEL:
+ // TODO(yoshiki): This is temporary. Change the asset when prepared.
Randy Smith (Not in Mondays) 2015/04/10 21:43:19 Could you give me context for this comment, prefer
yoshiki 2015/04/13 15:51:53 I changed the context in the comment. The Download
+ return IDR_DOWNLOAD_NOTIFICATION_MENU_DELETE;
case OPEN_WHEN_COMPLETE:
case ALWAYS_OPEN_TYPE:
case PLATFORM_OPEN:
- case CANCEL:
case LEARN_MORE_SCANNING:
case LEARN_MORE_INTERRUPTED:
return -1;

Powered by Google App Engine
This is Rietveld 408576698