chrome/browser/notifications/message_center_notification_manager.cc - Issue 1005393003: [Download Notification] Use NotificationUIManager instead of MessageCenter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 1005393003: [Download Notification] Use NotificationUIManager instead of MessageCenter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Do not stop ongoing download when closed and Add the "Cancel" button Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/notification/download_notification_manager.cc ('k') | chrome/browser/notifications/notification_test_util.cc » ('j') | chrome/browser/notifications/profile_notification.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notification_manager.cc

diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc

index 5e7802d4edf8e2d1e8f9adc2eb3a787afec20def..b5cb0554fc880b4eeaa80a2e174947343eedc98c 100644

--- a/chrome/browser/notifications/message_center_notification_manager.cc

+++ b/chrome/browser/notifications/message_center_notification_manager.cc

@@ -201,7 +201,14 @@ const Notification* MessageCenterNotificationManager::FindById(

profile_notifications_.find(profile_notification_id);

if (iter == profile_notifications_.end())

return NULL;

- return &(iter->second->notification());

+ // Update |notification| with the latest information from the message center.

+ ProfileNotification* profile_notification = iter->second;

+ profile_notification->CopyNotificationState(

+ message_center_->FindVisibleNotificationById(

+ iter->second->notification().id()));

Jun Mukai 2015/04/08 00:13:19 I believe this is not necessary anymore.

yoshiki 2015/04/08 00:54:05 Right. Removed.

+ return &(profile_notification->notification());

}

bool MessageCenterNotificationManager::CancelById(