[Download Notification] Use NotificationUIManager instead of MessageCenter

chrome/browser/notifications/message_center_notification_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/message_center_notification_manager.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
@@ skipping 183 matching lines @@
     ProfileID profile_id) const {
   // The profile pointer can be weak, the instance may have been destroyed, so
   // no profile method should be called inside this function.
 
   std::string profile_notification_id =
       ProfileNotification::GetProfileNotificationId(delegate_id, profile_id);
   NotificationMap::const_iterator iter =
       profile_notifications_.find(profile_notification_id);
   if (iter == profile_notifications_.end())
     return NULL;
-  return &(iter->second->notification());
+
+  // Update |notification| with the latest information from the message center.

[Jun Mukai, 2015/03/31 19:59:47]

This is weird. Is there some case where the state is inconsistent among message
center and the MessageCenterNotificationManager?
We should fix the inconsistency.

[yoshiki, 2015/04/01 04:10:49]

"shown_as_popup" and "read" flags are changed in the message center
(message_center::NotificationList) internally, and we need to sync them at
least.

[Jun Mukai, 2015/04/01 18:02:11]

Commented on the other part.
I believe FindById should not update anything on each notification, it's a
method to lookup existing ones.

Another suggestion is:
return
message_center_->FindVisibleNotificationById(iter->second->notification().id());

[yoshiki, 2015/04/06 02:22:18]

Thank you for the suggestion but we can't do it. FindVisibleNotificationById
returns the parent class (message_center::Notification), but FindById need to
return the child class (Notification defined in chrome/browser).

+  ProfileNotification* profile_notification = iter->second;
+  profile_notification->CopyNotificationState(
+      message_center_->FindVisibleNotificationById(
+          iter->second->notification().id()));
+
+  return &(profile_notification->notification());
 }
 
 bool MessageCenterNotificationManager::CancelById(
     const std::string& delegate_id,
     ProfileID profile_id) {
   // The profile pointer can be weak, the instance may have been destroyed, so
   // no profile method should be called inside this function.
 
   std::string profile_notification_id =
       ProfileNotification::GetProfileNotificationId(delegate_id, profile_id);
@@ skipping 187 matching lines @@
        it != registry->enabled_extensions().end();
        ++it) {
     if ((*it->get()).permissions_data()->HasAPIPermission(
             extensions::APIPermission::ID::kNotificationProvider)) {
       extension_id = (*it->get()).id();
       return extension_id;
     }
   }
   return extension_id;
 }