[Download Notification] Use NotificationUIManager instead of MessageCenter

chrome/browser/download/notification/download_notification_item.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_NOTIFICATION_DOWNLOAD_NOTIFICATION_ITEM_H_
 #define CHROME_BROWSER_DOWNLOAD_NOTIFICATION_DOWNLOAD_NOTIFICATION_ITEM_H_
 
 #include "chrome/browser/download/notification/download_notification_item.h"
 
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/download/download_commands.h"
+#include "chrome/browser/notifications/notification.h"
+#include "chrome/browser/notifications/notification_delegate.h"
+#include "chrome/browser/notifications/notification_test_util.h"
 #include "content/public/browser/download_item.h"
 #include "grit/theme_resources.h"
 #include "ui/message_center/message_center.h"
 #include "ui/message_center/message_center_observer.h"
-#include "ui/message_center/notification.h"
-#include "ui/message_center/notification_delegate.h"
-
-using message_center::Notification;
 
 namespace test {
 class DownloadNotificationItemTest;
 }
 
-class DownloadNotificationItem : public content::DownloadItem::Observer {
+class DownloadNotificationItem
+    : public base::SupportsWeakPtr<DownloadNotificationItem>,

[Randy Smith (Not in Mondays), 2015/04/14 00:02:00]

Ok, I'll bite.  What is this used for?  After poking around the source for a
while, I can't figure it out.

[yoshiki, 2015/04/15 02:59:51]

That was no longer used in the this patchset. Removed.

+      public content::DownloadItem::Observer {
  public:
   class Delegate {
    public:
     virtual void OnDownloadStarted(DownloadNotificationItem* item) = 0;
     virtual void OnDownloadStopped(DownloadNotificationItem* item) = 0;
     virtual void OnDownloadRemoved(DownloadNotificationItem* item) = 0;
   };
 
-  DownloadNotificationItem(content::DownloadItem* item, Delegate* delegate);
+  static const char kDownloadNotificationOrigin[];
+
+  DownloadNotificationItem(content::DownloadItem* item,
+                           Profile* profile,
+                           Delegate* delegate);
 
   ~DownloadNotificationItem() override;
 
  private:
-  class NotificationWatcher : public message_center::NotificationDelegate,
-                              public message_center::MessageCenterObserver {
+  friend class test::DownloadNotificationItemTest;
+
+  class NotificationWatcher : public NotificationDelegate {
    public:
     explicit NotificationWatcher(DownloadNotificationItem* item);
 
+    // NotificationDelegate overrides:
+    void Close(bool by_user) override;
+    void Click() override;
+    bool HasClickedListener() override;
+    void ButtonClick(int button_index) override;
+    std::string id() const override;
+
    private:
     ~NotificationWatcher() override;
 
-    // message_center::NotificationDelegate overrides:
-    void Close(bool by_user) override;
-    void Click() override;
-    bool HasClickedListener() override;
-    void ButtonClick(int button_index) override;
-
-    // message_center::MessageCenterObserver overrides:
-    void OnNotificationRemoved(const std::string& id, bool by_user) override;
-
     DownloadNotificationItem* item_;
   };
 
+  // Replaces the NotificationUIManager for tests.
+  static void SetStubNotificationUIManagerForTesting(
+      StubNotificationUIManager* stub_notification_ui_manager) {
+    stub_notification_ui_manager_for_testing_ = stub_notification_ui_manager;
+  }
+
+  // Methods called from NotificationWatcher.
   void OnNotificationClick();
   void OnNotificationButtonClick(int button_index);
-  void OnNotificationClose(bool by_user);
-  void OnNotificationRemoved(bool by_user);
 
   // DownloadItem::Observer overrides:
   void OnDownloadUpdated(content::DownloadItem* item) override;
   void OnDownloadOpened(content::DownloadItem* item) override;
   void OnDownloadRemoved(content::DownloadItem* item) override;
   void OnDownloadDestroyed(content::DownloadItem* item) override;
 
   void UpdateNotificationData();
   void SetNotificationImage(int resource_id);
 
+  NotificationUIManager* notification_ui_manager() const;
+
+  // For testing. This is set by SetStubNotificationUIManagerForTesting method.
+  static StubNotificationUIManager* stub_notification_ui_manager_for_testing_;

[Randy Smith (Not in Mondays), 2015/04/14 00:02:00]

nit: The style guide specifies that routines need to be before data members
(http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Declaration_O...).

[yoshiki, 2015/04/15 02:59:51]

Thank you for guidance. Done.

+
   // Returns a short one-line status string for the download.
   base::string16 GetTitle() const;
 
   // Returns a short one-line status string for a download command.
   base::string16 GetCommandLabel(DownloadCommands::Command command) const;
 
   // Get the warning test to notify a dangerous download. Should only be called
   // if IsDangerous() is true.
   base::string16 GetWarningText() const;
 
   scoped_ptr<std::vector<DownloadCommands::Command>> GetPossibleActions() const;
 
   bool openable_;
   bool downloading_;
-  bool reshow_after_remove_;
   int image_resource_id_;
+  Profile* profile_;
   scoped_refptr<NotificationWatcher> watcher_;
 
-  message_center::MessageCenter* message_center_;
   scoped_ptr<Notification> notification_;
 
   content::DownloadItem* item_;
   scoped_ptr<std::vector<DownloadCommands::Command>> button_actions_;
 
   Delegate* const delegate_;
 
-  friend class test::DownloadNotificationItemTest;
-
   DISALLOW_COPY_AND_ASSIGN(DownloadNotificationItem);
 };
 
 #endif  // CHROME_BROWSER_DOWNLOAD_NOTIFICATION_DOWNLOAD_NOTIFICATION_ITEM_H_