[Download Notification] Use NotificationUIManager instead of MessageCenter

chrome/browser/download/notification/download_notification_item_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/notification/download_notification_item.h"
 
 #include "base/run_loop.h"
 #include "base/test/test_simple_task_runner.h"
 #include "base/thread_task_runner_handle.h"
+#include "chrome/test/base/testing_browser_process.h"
+#include "chrome/test/base/testing_profile.h"
+#include "chrome/test/base/testing_profile_manager.h"
 #include "content/public/test/mock_download_item.h"
 #include "content/public/test/mock_download_manager.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "ui/message_center/fake_message_center.h"
 
 using testing::NiceMock;
 using testing::Return;
 using testing::_;
 
@@ skipping 94 matching lines @@
         message_center()->GetPopupNotifications();
     for (auto it = popups.begin(); it != popups.end(); it++) {
       if ((*it)->id() == notification_id) {
         return true;
       }
     }
     return false;
   }
 
   void CreateDownloadNotificationItem() {
-    download_notification_item_.reset(
-        new DownloadNotificationItem(download_item_.get(), &delegate_));
+    TestingProfileManager profile_manager(TestingBrowserProcess::GetGlobal());
+    ASSERT_TRUE(profile_manager.SetUp());

[asanka, 2015/03/24 18:36:15]

Move the TestingProfileManager construction and SetUp() call to
DownloadNotificationItemTest::SetUp() above.

[yoshiki, 2015/03/25 05:30:25]

Done. I moved the construction of Profile as well.

+    Profile* profile = profile_manager.CreateTestingProfile("test-user");

[asanka, 2015/03/24 18:36:15]

Can't we at least test whether two notifications created by profiles with
different names end up with different profile_id()s?

[yoshiki, 2015/03/25 05:30:25]

That's good idea. But I think the multi-user test should be covered by browser
test rather than unit test. I'm planning to add a browser test including the
multi-user test later. 

[asanka, 2015/03/25 21:04:48]

It would be great if such a test was part of this CL. I understand that
notifications are a work in progress, but unless there are very good reasons,
tests should go in along with the code that implements functionality.

+
+    download_notification_item_.reset(new DownloadNotificationItem(
+        download_item_.get(), profile, &delegate_));
   }
 
   scoped_refptr<base::TestSimpleTaskRunner> runner_;
   base::ThreadTaskRunnerHandle runner_handler_;
 
   MockDownloadNotificationItemDelegate delegate_;
   scoped_ptr<NiceMock<content::MockDownloadItem>> download_item_;
   scoped_ptr<DownloadNotificationItem> download_notification_item_;
 };
 
@@ skipping 124 matching lines @@
 
   // Checks OnDownloadRemoved().
   EXPECT_EQ(0u, delegate_.GetOnDownloadRemovedCallCount());
   download_item_->NotifyObserversDownloadRemoved();
   EXPECT_EQ(1u, delegate_.GetOnDownloadRemovedCallCount());
 
   download_item_.reset();
 }
 
 }  // namespace test