Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 1005343004: Update visible ids if any of their thumbnails are invalid (Closed)

Created:
5 years, 9 months ago by Jaekyun Seok (inactive)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update visible ids if any of their thumbnails are invalid For now, ThumbnailStore::UpdateVisibleIds only compares tab id lists to determin whether updating visible ids is needed or not. But we need to update them if any of their thumbnails are invalid. BUG=468242 Committed: https://crrev.com/0ca3e6d8396850d5f529b8d859a684be2c3e5073 Cr-Commit-Position: refs/heads/master@{#321305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/android/thumbnail/thumbnail_store.cc View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jaekyun Seok (inactive)
Please review this CL.
5 years, 9 months ago (2015-03-19 04:07:14 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-19 05:41:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005343004/1
5 years, 9 months ago (2015-03-19 05:47:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 06:19:56 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 06:21:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ca3e6d8396850d5f529b8d859a684be2c3e5073
Cr-Commit-Position: refs/heads/master@{#321305}

Powered by Google App Engine
This is Rietveld 408576698