Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1005333002: Update V8 DEPS. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update V8 DEPS. Rolling v8/tools/clang to 37246cb63b9720d6fe74b473210291007e49297b TBR=jochen@chromium.org BUG=chromium:466099 LOG=n Committed: https://crrev.com/bab55d24aed533b7a86497bbc8f4a2b90d0921c3 Cr-Commit-Position: refs/heads/master@{#27200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/standalone.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005333002/1
5 years, 9 months ago (2015-03-14 18:40:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-14 18:41:33 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bab55d24aed533b7a86497bbc8f4a2b90d0921c3 Cr-Commit-Position: refs/heads/master@{#27200}
5 years, 9 months ago (2015-03-14 18:41:49 UTC) #4
Nico
On 2015/03/14 18:41:49, I haz the power (commit-bot) wrote: > Patchset 1 (id:??) landed as ...
5 years, 9 months ago (2015-03-14 20:16:39 UTC) #5
Yang
On 2015/03/14 20:16:39, Nico (traveling) wrote: > On 2015/03/14 18:41:49, I haz the power (commit-bot) ...
5 years, 9 months ago (2015-03-15 04:22:03 UTC) #6
Yang
On 2015/03/15 04:22:03, Yang wrote: > On 2015/03/14 20:16:39, Nico (traveling) wrote: > > On ...
5 years, 9 months ago (2015-03-15 04:22:39 UTC) #7
Nico
5 years, 9 months ago (2015-03-20 00:18:56 UTC) #8
Message was sent while issue was closed.
On 2015/03/15 04:22:03, Yang wrote:
> On 2015/03/14 20:16:39, Nico (traveling) wrote:
> > On 2015/03/14 18:41:49, I haz the power (commit-bot) wrote:
> > > Patchset 1 (id:??) landed as
> > > https://crrev.com/bab55d24aed533b7a86497bbc8f4a2b90d0921c3
> > > Cr-Commit-Position: refs/heads/master@{#27200}
> > 
> > Do you not support building on Mac?
> 
> Did recent changes to BUILD.gn break something?

(I'm asking because cflags is only used on linux/android/chromeos in gyp, and
this doesn't modify xcode_settings: { 'OTHER_WARNING_FLAGS': '..' })

Powered by Google App Engine
This is Rietveld 408576698