Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1005303002: Fix for console error while selecting 'Keep local data only unitl you quit..' in cookies in content… (Closed)

Created:
5 years, 9 months ago by Deepak
Modified:
5 years, 9 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for console error while selecting 'Keep local data only unitl you quit..' in cookies in content settings. we was using 'cookies_session_only' as filter and while getting string value for cookies we are passing cookiesSession from setContentFilterSettingsValue() as we are fetching value and making its first character uppercase and concatenating with group and passing this to get string via getString(). we are getting string value as undefined that causing console error. Changes done so that proper value for cookiesSession will be fetched. BUG=466976 Committed: https://crrev.com/5eacc0c1e940f17080abeea357e600ed071e3b16 Cr-Commit-Position: refs/heads/master@{#321750}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/options/content_settings.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Deepak
PTAL. Thanks
5 years, 9 months ago (2015-03-14 10:05:26 UTC) #2
Deepak
@dbeam PTAL at this small change for fixing console error. Thanks
5 years, 9 months ago (2015-03-17 02:48:44 UTC) #4
Deepak
@dbeam PTAL at this small change for fixing console error. Thanks
5 years, 9 months ago (2015-03-19 10:23:39 UTC) #5
Deepak
@dbeam PTAL at this small change for fixing console error. Thanks
5 years, 9 months ago (2015-03-20 16:12:16 UTC) #6
Bernhard Bauer
LGTM, thanks! BTW: There is some more opportunity for cleanup here, to make all of ...
5 years, 9 months ago (2015-03-23 08:23:28 UTC) #7
Deepak
On 2015/03/23 08:23:28, Bernhard Bauer wrote: > LGTM, thanks! > > BTW: There is some ...
5 years, 9 months ago (2015-03-23 08:42:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005303002/1
5 years, 9 months ago (2015-03-23 08:43:19 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 09:41:08 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 09:41:48 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5eacc0c1e940f17080abeea357e600ed071e3b16
Cr-Commit-Position: refs/heads/master@{#321750}

Powered by Google App Engine
This is Rietveld 408576698