Re-land: Resurrect Aura Linux accessibility.

Re-land: Resurrect Aura Linux accessibility.

1. Avoids overloading in a C linkage block (mostynb)
2. Only compiles ATK support if use_x11 is true
    to avoid ChromeCast issue (gunsch)
3. Updates chrome/installer/linux expectations

Original changelist: https://codereview.chromium.org/975113002/

BUG=463671
R=thestig@chromium.org
TBR=dpranke, plundblad, sky

Committed: https://chromium.googlesource.com/chromium/src/+/0e9bcce45c12479259c705a07a6b4b1e73b84bf2

[dmazzoni, 2015-03-14 06:34:38]

dmazzoni@chromium.org changed reviewers:
+ thestig@chromium.org

[dmazzoni, 2015-03-14 06:34:38]

+thestig for chrome/installer/linux changes

[Lei Zhang, 2015-03-16 19:20:42]

lgtm

[commit-bot: I haz the power, 2015-03-16 20:54:32]

Patchset 3 (id:??) landed as
https://crrev.com/0e9bcce45c12479259c705a07a6b4b1e73b84bf2
Cr-Commit-Position: refs/heads/master@{#320790}

[dmazzoni, 2015-03-16 20:54:45]

Committed patchset #3 (id:40001) manually as
0e9bcce45c12479259c705a07a6b4b1e73b84bf2 (presubmit successful).

[gunsch, 2015-03-16 21:25:11]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-03-16 21:25:11]

https://codereview.chromium.org/1005293002/diff/40001/ui/views/views.gyp
File ui/views/views.gyp (right):

https://codereview.chromium.org/1005293002/diff/40001/ui/views/views.gyp#newc...
ui/views/views.gyp:640: '../../build/linux/system.gyp:atk',
Same issue reported on the first iteration of this CL:

This definition is guarded with "use_ozone==0", but the condition is not.

This breaks Chromecast (trybot in progress), which meets:
OS=="linux"
chromeos==0
use_ozone==1

could you take a look?

[gunsch, 2015-03-16 21:28:53]

https://codereview.chromium.org/1005293002/diff/40001/ui/views/views.gyp
File ui/views/views.gyp (right):

https://codereview.chromium.org/1005293002/diff/40001/ui/views/views.gyp#newc...
ui/views/views.gyp:640: '../../build/linux/system.gyp:atk',
On 2015/03/16 21:25:11, gunsch wrote:
> Same issue reported on the first iteration of this CL:
> 
> This definition is guarded with "use_ozone==0", but the condition is not.
> 
> This breaks Chromecast (trybot in progress), which meets:
> OS=="linux"
> chromeos==0
> use_ozone==1
> 
> could you take a look?

Actually, I'll just send you a CL

[gunsch, 2015-03-16 21:28:53]

https://codereview.chromium.org/1005293002/diff/40001/ui/views/views.gyp
File ui/views/views.gyp (right):

https://codereview.chromium.org/1005293002/diff/40001/ui/views/views.gyp#newc...
ui/views/views.gyp:640: '../../build/linux/system.gyp:atk',
On 2015/03/16 21:25:11, gunsch wrote:
> Same issue reported on the first iteration of this CL:
> 
> This definition is guarded with "use_ozone==0", but the condition is not.
> 
> This breaks Chromecast (trybot in progress), which meets:
> OS=="linux"
> chromeos==0
> use_ozone==1
> 
> could you take a look?

Actually, I'll just send you a CL

[dmazzoni, 2015-03-16 21:32:15]

On Mon, Mar 16, 2015 at 2:28 PM, <gunsch@chromium.org> wrote:

> This breaks Chromecast (trybot in progress), which meets:
>> OS=="linux"
>> chromeos==0
>> use_ozone==1
>>
>
could you take a look?
>>
>
> Actually, I'll just send you a CL


Thanks. I did try to address that in this re-land but I must have still had
a bad assumption.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.