Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1069)

Issue 1005263002: Revert of Add terrible workaround to fix stencil clear crash on S3. (Closed)

Created:
5 years, 9 months ago by ccameron
Modified:
5 years, 9 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add terrible workaround to fix stencil clear crash on S3. (patchset #1 id:1 of https://codereview.chromium.org/1001693003/) Reason for revert: Needs to be reverted in order to cleanly revert https://codereview.chromium.org/949263002 That one needs to be reverted to fix black boxes with GPU raster, and GPU bot failures. BUG=466690 Original issue's description: > Add terrible workaround to fix stencil clear crash on S3. > > BUG=skia:3525 > > Committed: https://skia.googlesource.com/skia/+/084340bb9bbb538baf02a11ac36e29f0d9cdc493 TBR=joshualitt@google.com,bsalomon@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3525 Committed: https://skia.googlesource.com/skia/+/3700c9a2d3067135229cbd510f604df875e5c268

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M src/gpu/gl/GrGLGpu.cpp View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
ccameron
Created Revert of Add terrible workaround to fix stencil clear crash on S3.
5 years, 9 months ago (2015-03-13 23:03:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005263002/1
5 years, 9 months ago (2015-03-13 23:03:20 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-13 23:03:20 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 9 months ago (2015-03-14 05:03:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005263002/1
5 years, 9 months ago (2015-03-14 19:02:20 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-14 19:02:21 UTC) #8
bsalomon
On 2015/03/14 19:02:21, I haz the power (commit-bot) wrote: > Note for Reviewers: > The ...
5 years, 9 months ago (2015-03-14 19:05:21 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 19:06:58 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3700c9a2d3067135229cbd510f604df875e5c268

Powered by Google App Engine
This is Rietveld 408576698