Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1005243002: Make sure the test holds a reference of secondDataChannel. (Closed)

Created:
5 years, 9 months ago by jiayl
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure the test holds a reference of secondDataChannel. BUG=467097 Committed: https://crrev.com/194c77793f7158729c91cbbefd6f813ba1ccf203 Cr-Commit-Position: refs/heads/master@{#321155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/test/data/media/peerconnection-call.html View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jiayl
PTAL
5 years, 9 months ago (2015-03-13 22:21:45 UTC) #2
rmcilroy
On 2015/03/13 22:21:45, jiayl wrote: > PTAL This works for me and fixes the issues ...
5 years, 9 months ago (2015-03-18 10:53:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005243002/1
5 years, 9 months ago (2015-03-18 16:11:05 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 17:14:56 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/194c77793f7158729c91cbbefd6f813ba1ccf203 Cr-Commit-Position: refs/heads/master@{#321155}
5 years, 9 months ago (2015-03-18 17:16:13 UTC) #7
tommi (sloooow) - chröme
lgtm (sorry about slowness). Isn't there still though an issue in blink wrt gc-ing data ...
5 years, 9 months ago (2015-03-20 13:10:49 UTC) #9
jiayl
5 years, 9 months ago (2015-03-20 16:11:31 UTC) #10
Message was sent while issue was closed.
The blink issue is tracked separately.

On Fri, Mar 20, 2015 at 6:10 AM, <tommi@chromium.org> wrote:

> lgtm (sorry about slowness).
>
> Isn't there still though an issue in blink wrt gc-ing data channels?
>
> https://codereview.chromium.org/1005243002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698