Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1005223002: Blink: Replace all "plug-in" with "plugin". (Closed)

Created:
5 years, 9 months ago by tommycli
Modified:
5 years, 9 months ago
Reviewers:
chrishtr
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-rendering, dcheng, dglazkov+blink, Dominik Röttsches, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, slimming-paint-reviews_chromium.org, vivekg_samsung, vivekg, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : merge #

Patch Set 4 : Update a bunch of LayoutTests 'expected' also. #

Patch Set 5 : #

Patch Set 6 : merge. #

Patch Set 7 : Revert netscape-dom-access tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -181 lines) Patch
M LayoutTests/fast/dom/Window/Plug-ins.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/layers/clip-rects-transformed.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/layers/clip-rects-transformed-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/layers/clip-rects-transformed-2-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/layers/clip-rects-transformed-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/cross-frame-object-access-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/local-geturl-from-remote.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/local-geturl-from-remote-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/npapi-response-headers.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/npapi-response-headers-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/resources/cross-frame-object-access.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/third-party-cookie-accept-policy.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/plugins/third-party-cookie-accept-policy-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/empty-url-plugin-in-frame.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/empty-url-plugin-in-frame-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/security/mixedContent/insecure-plugin-in-iframe-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/linux/plugins/keyboard-events-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/mac/plugins/keyboard-events-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/platform/win/plugins/keyboard-events-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/clicking-missing-plugin-fires-delegate.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/clicking-missing-plugin-fires-delegate-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/destroy-during-npp-new.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/destroy-during-npp-new-object-with-fallback-content.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/destroy-on-setwindow.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/plugins/destroy-on-setwindow-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/destroy-stream-twice.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/destroy-stream-twice-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/embed-prefers-plugins-for-images.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/embed-prefers-plugins-for-images-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/get-url-with-javascript-destroying-plugin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/get-url-with-javascript-destroying-plugin-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/instance-available-before-stylesheets-loaded.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/plugins/instance-available-before-stylesheets-loaded-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/instance-available-before-stylesheets-loaded-object.html View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/plugins/instance-available-before-stylesheets-loaded-object-expected.txt View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/js-from-destroy.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/keyboard-events.html View 2 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/plugins/missing-plugin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/missing-plugin-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-destroy-plugin-script-objects.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-destroy-plugin-script-objects-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-dom-access-and-reload.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-dom-access-and-reload-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-plugin-setwindow-size.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-plugin-setwindow-size-2.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-plugin-setwindow-size-2-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/netscape-plugin-setwindow-size-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npp-new-fails.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/npp-new-fails-expected.txt View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/npruntime/browser-object-identity-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/get-property-return-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/get-property-return-value-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/np-deallocate-called-before-np-shutdown.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/object-from-destroyed-plugin.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/npruntime/object-from-destroyed-plugin-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/object-from-destroyed-plugin-in-subframe.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/round-trip-npobject.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/plugins/npruntime/round-trip-npobject-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/script-tests/browser-object-identity.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/npruntime/set-property.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/npruntime/set-property-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/override-node-method.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/override-node-method-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/plugin-initiate-popup-window.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/plugin-javascript-access.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/plugins/resize-from-plugin-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/resources/resize-from-plugin-frame.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/return-error-from-new-stream-doesnt-invoke-destroy-stream-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/return-negative-one-from-write.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/plugins/return-negative-one-from-write-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ManualTests/NPN_Invoke/main.c View 1 chunk +1 line, -1 line 0 comments Download
M ManualTests/divx-plugin-fails-to-draw.html View 1 chunk +2 lines, -2 lines 0 comments Download
M ManualTests/nested-plug-ins.html View 1 1 chunk +0 lines, -45 lines 0 comments Download
A + ManualTests/nested-plugins.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ManualTests/plug-in-mutates-NSView-hierarchy-during-resize.html View 1 chunk +1 line, -1 line 0 comments Download
M ManualTests/plugins/timeout-dialog-displayed-over-navigation.html View 1 chunk +5 lines, -5 lines 0 comments Download
D ManualTests/resources/nested-plug-ins-inner-frame.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M ManualTests/resources/nested-plug-ins-outer-frame.html View 1 1 chunk +0 lines, -3 lines 0 comments Download
A + ManualTests/resources/nested-plugins-inner-frame.html View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + ManualTests/resources/nested-plugins-outer-frame.html View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMImplementation.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/Settings.in View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutEmbeddedObject.h View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutPart.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutPart.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Page.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/core/paint/PartPainter.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameWidgetImpl.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebViewImpl.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M public/web/WebContentSettingsClient.h View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (12 generated)
tommycli
chrishtr: PTAL. This is a mechanical change that standardizes "plug-in" vs "plugin". We chose "plugin".
5 years, 9 months ago (2015-03-13 22:16:36 UTC) #2
chrishtr
lgtm
5 years, 9 months ago (2015-03-13 22:41:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005223002/40001
5 years, 9 months ago (2015-03-13 22:42:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/52273)
5 years, 9 months ago (2015-03-14 05:55:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005223002/40001
5 years, 9 months ago (2015-03-16 17:26:34 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/52494)
5 years, 9 months ago (2015-03-17 01:04:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005223002/40001
5 years, 9 months ago (2015-03-17 20:32:49 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/52772)
5 years, 9 months ago (2015-03-18 04:03:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005223002/60001
5 years, 9 months ago (2015-03-19 00:29:33 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/55643)
5 years, 9 months ago (2015-03-19 03:11:39 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005223002/120001
5 years, 9 months ago (2015-03-19 22:07:46 UTC) #23
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:12:36 UTC) #24
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192200

Powered by Google App Engine
This is Rietveld 408576698