Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1005213004: Revert "add new signature so skia can rely on it (subclass of SkDevice)" (Closed)

Created:
5 years, 9 months ago by reed2
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "add new signature so skia can rely on it (subclass of SkDevice)" Need to starge a pre-cl in skia first (and then add override to chrome's classes) This reverts commit 6e54eb96463218b8ee70c298b17d9d5ef78c794a. BUG= TBR=fmalita@chromium.org Committed: https://crrev.com/3d4669df835748357f3865d6d01a155fe72f298e Cr-Commit-Position: refs/heads/master@{#320643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M skia/ext/bitmap_platform_device_cairo.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_cairo.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M skia/ext/bitmap_platform_device_skia.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_skia.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005213004/1
5 years, 9 months ago (2015-03-14 03:30:17 UTC) #2
reed2
plan to land this in skia after this revert https://codereview.chromium.org/1006923004 and then reland this CL ...
5 years, 9 months ago (2015-03-14 03:30:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-14 04:33:04 UTC) #4
commit-bot: I haz the power
5 years, 9 months ago (2015-03-14 04:33:40 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d4669df835748357f3865d6d01a155fe72f298e
Cr-Commit-Position: refs/heads/master@{#320643}

Powered by Google App Engine
This is Rietveld 408576698