Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1005213002: Add missing CdmKeyInformation enum values (Closed)

Created:
5 years, 9 months ago by jrummell
Modified:
5 years, 9 months ago
CC:
binji+watch_chromium.org, bradnelson+warch_chromium.org, chromium-reviews, darin-cc_chromium.org, eme-reviews_chromium.org, feature-media-reviews_chromium.org, ihf+watch_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, raymes+watch_chromium.org, teravest+watch_chromium.org, tzik, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing CdmKeyInformation enum values Latest EME spec has added new values to MediaKeyStatus (https://w3c.github.io/encrypted-media/#idl-def-MediaKeyStatus), so pass these though Pepper. Changes to the CDM interface will come later. BUG=465592 TEST=none, as the new values not currently used Committed: https://crrev.com/7c9fe86c47dd929b4c78ecf9a6492a243739cc99 Cr-Commit-Position: refs/heads/master@{#320982}

Patch Set 1 #

Patch Set 2 : Rename enum for Windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -5 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/base/cdm_key_information.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M media/blink/webcontentdecryptionmodulesession_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M media/cdm/ppapi/external_clear_key/clear_key_cdm.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M ppapi/api/private/pp_content_decryptor.idl View 1 chunk +3 lines, -1 line 0 comments Download
M ppapi/c/private/pp_content_decryptor.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
jrummell
PTAL.
5 years, 9 months ago (2015-03-13 21:56:56 UTC) #2
sandersd (OOO until July 31)
lgtm
5 years, 9 months ago (2015-03-13 22:15:09 UTC) #3
jrummell
+dcheng@, +dmichael@ for OWNERS review. Just adding values to an enum passed through Pepper.
5 years, 9 months ago (2015-03-13 23:04:58 UTC) #5
dcheng
rs lgtm
5 years, 9 months ago (2015-03-13 23:25:47 UTC) #6
jrummell
ping dmichael@ for OWNERS review. Just adding values to an enum passed through Pepper.
5 years, 9 months ago (2015-03-16 20:45:19 UTC) #7
dmichael (off chromium)
lgtm
5 years, 9 months ago (2015-03-16 21:59:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005213002/1
5 years, 9 months ago (2015-03-16 22:04:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/38228)
5 years, 9 months ago (2015-03-17 02:41:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005213002/20001
5 years, 9 months ago (2015-03-17 20:16:20 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 21:47:05 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 21:47:43 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c9fe86c47dd929b4c78ecf9a6492a243739cc99
Cr-Commit-Position: refs/heads/master@{#320982}

Powered by Google App Engine
This is Rietveld 408576698