Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1005203002: Telemetry: Move ProfileCreator to tools/perf/profile_creator. (Closed)

Created:
5 years, 9 months ago by erikchen
Modified:
5 years, 9 months ago
Reviewers:
dtu
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Telemetry: Move ProfileGenerator to tools/perf/profile_creator. I moved ProfileGenerator and ProfileCreator from tools/telemetry/... into tools/perf/profile_creator. BUG=447457 Committed: https://crrev.com/5417876e0f08577e85badc5e765c3fc4dd6f0fa0 Cr-Commit-Position: refs/heads/master@{#321231}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -252 lines) Patch
M tools/perf/benchmarks/session_restore.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/generate_profile View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/extensions_profile_creator.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/large_profile_creator.py View 1 chunk +1 line, -1 line 0 comments Download
A + tools/perf/profile_creators/profile_creator.py View 1 chunk +0 lines, -2 lines 0 comments Download
A + tools/perf/profile_creators/profile_generator.py View 1 1 chunk +1 line, -4 lines 0 comments Download
A + tools/perf/profile_creators/profile_generator_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/profile_creators/small_profile_creator.py View 1 chunk +1 line, -1 line 0 comments Download
D tools/telemetry/telemetry/page/profile_creator.py View 1 chunk +0 lines, -25 lines 0 comments Download
D tools/telemetry/telemetry/page/profile_generator.py View 1 chunk +0 lines, -147 lines 0 comments Download
D tools/telemetry/telemetry/page/profile_generator_unittest.py View 1 chunk +0 lines, -68 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
dtu: Please review.
5 years, 9 months ago (2015-03-13 21:41:47 UTC) #2
erikchen
On 2015/03/13 21:41:47, erikchen wrote: > dtu: Please review. ping?
5 years, 9 months ago (2015-03-18 03:17:10 UTC) #3
dtu
lgtm
5 years, 9 months ago (2015-03-18 21:40:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005203002/20001
5 years, 9 months ago (2015-03-18 21:42:00 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-18 23:20:38 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 23:21:35 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5417876e0f08577e85badc5e765c3fc4dd6f0fa0
Cr-Commit-Position: refs/heads/master@{#321231}

Powered by Google App Engine
This is Rietveld 408576698