Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Unified Diff: content/common/indexed_db/indexed_db_dispatcher.h

Issue 10052005: Add DCHECK to ensure IndexedDBDispatcher doesn't get re-created. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix kHasBeenDeleted Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/common/indexed_db/indexed_db_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/indexed_db/indexed_db_dispatcher.h
diff --git a/content/common/indexed_db/indexed_db_dispatcher.h b/content/common/indexed_db/indexed_db_dispatcher.h
index f48e7c2da3a3980420935ae4ba087c33cfa5778d..761c0357d950f2cb0b195a7e9a9b154891ca7c94 100644
--- a/content/common/indexed_db/indexed_db_dispatcher.h
+++ b/content/common/indexed_db/indexed_db_dispatcher.h
@@ -49,6 +49,11 @@ CONTENT_EXPORT extern const size_t kMaxIDBValueSizeInBytes;
class CONTENT_EXPORT IndexedDBDispatcher
: public webkit_glue::WorkerTaskRunner::Observer {
public:
+ // Constructor made public to allow RenderThreadImpl to own a copy without
+ // failing a NOTREACHED in ThreadSpecificInstance in tests that instantiate
+ // two copies of RenderThreadImpl on the same thread. Everyone else probably
+ // wants to use ThreadSpecificInstance().
+ IndexedDBDispatcher();
virtual ~IndexedDBDispatcher();
static IndexedDBDispatcher* ThreadSpecificInstance();
@@ -209,7 +214,6 @@ class CONTENT_EXPORT IndexedDBDispatcher
private:
FRIEND_TEST_ALL_PREFIXES(IndexedDBDispatcherTest, ValueSizeTest);
- IndexedDBDispatcher();
// IDBCallback message handlers.
void OnSuccessNull(int32 response_id);
void OnSuccessIDBDatabase(int32 thread_id,
« no previous file with comments | « no previous file | content/common/indexed_db/indexed_db_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698