Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: components/nacl/browser/pnacl_translation_cache_unittest.cc

Issue 1005173006: Add a switch for using PNaCl Subzero and use it for -O0 translation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: separate subzero / llc cache keys Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/pnacl_translation_cache_unittest.cc
diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc
index dcba62f7b61c7d183096e2585e82f7ccc683c9ef..a8c8093a7a7f90d36a0544517b150b2159a084b5 100644
--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc
+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc
@@ -177,6 +177,13 @@ TEST(PnaclTranslationCacheKeyTest, CacheKeyTest) {
"modified:1995:11:15:6:25:24:0:UTC;etag:;"
"sandbox:x86-32;extra_flags:;",
PnaclTranslationCache::GetKey(info));
+ // Check that Subzero gets a different cache key.
+ info.use_subzero = true;
+ EXPECT_EQ("ABI:2;opt:2subzero;URL:http://www.google.com/;"
+ "modified:1995:11:15:6:25:24:0:UTC;etag:;"
+ "sandbox:x86-32;extra_flags:;",
+ PnaclTranslationCache::GetKey(info));
+ info.use_subzero = false;
info.etag = std::string("etag");
EXPECT_EQ("ABI:2;opt:2;URL:http://www.google.com/;"
"modified:1995:11:15:6:25:24:0:UTC;etag:etag;"

Powered by Google App Engine
This is Rietveld 408576698