Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: net/websockets/websocket_end_to_end_test.cc

Issue 1005113002: WebSocket header continuations test case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/websocket/header-continuation_wsh.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/websockets/websocket_end_to_end_test.cc
diff --git a/net/websockets/websocket_end_to_end_test.cc b/net/websockets/websocket_end_to_end_test.cc
index 2fbc20b6ae65f7a984412a22482aa1f2f2aa9e76..e652fe05408f6baef7eb81ea029219dee1ff01e4 100644
--- a/net/websockets/websocket_end_to_end_test.cc
+++ b/net/websockets/websocket_end_to_end_test.cc
@@ -470,6 +470,24 @@ TEST_F(WebSocketEndToEndTest, DISABLED_ON_ANDROID(TrailingWhitespace)) {
EXPECT_EQ("sip", event_interface_->selected_subprotocol());
}
+// This is a regression test for crbug.com/169448 "WebSockets should support
+// header continuations"
+// TODO(ricea): HTTP continuation headers have been deprecated by RFC7230. If
+// support for continuation headers is removed from Chrome, then this test will
+// break and should be removed.
+TEST_F(WebSocketEndToEndTest, DISABLED_ON_ANDROID(HeaderContinuations)) {
+ SpawnedTestServer ws_server(SpawnedTestServer::TYPE_WS,
+ SpawnedTestServer::kLocalhost,
+ GetWebSocketTestDataDirectory());
+ ASSERT_TRUE(ws_server.Start());
+
+ GURL ws_url = ws_server.GetURL("header-continuation");
+
+ EXPECT_TRUE(ConnectAndWait(ws_url));
+ EXPECT_EQ("permessage-deflate; server_max_window_bits=10",
+ event_interface_->extensions());
+}
+
} // namespace
} // namespace net
« no previous file with comments | « net/data/websocket/header-continuation_wsh.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698