Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(802)

Issue 1005103003: Small change to add a callto retrieve a malloc SkDescriptor from SkPaint (Closed)

Created:
5 years, 9 months ago by joshua.litt
Modified:
5 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Call to retrieve SkDescriptor for SkScalarContext from SkPaint. Committed: https://skia.googlesource.com/skia/+/fd45079314b739979492601fc7a242aff24c58a3

Patch Set 1 #

Patch Set 2 : modified to return const SkData #

Total comments: 1

Patch Set 3 : change name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -78 lines) Patch
M include/core/SkPaint.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkPaint.cpp View 1 2 1 chunk +135 lines, -78 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
joshualitt
PTAL
5 years, 9 months ago (2015-03-13 14:22:11 UTC) #2
reed1
+ben I'd rather not make this new api public. Can we friend the one caller, ...
5 years, 9 months ago (2015-03-13 14:26:46 UTC) #4
joshualitt
On 2015/03/13 14:26:46, reed1 wrote: > +ben > > I'd rather not make this new ...
5 years, 9 months ago (2015-03-13 14:42:58 UTC) #5
bungeman-skia
https://codereview.chromium.org/1005103003/diff/20001/include/core/SkPaint.h File include/core/SkPaint.h (right): https://codereview.chromium.org/1005103003/diff/20001/include/core/SkPaint.h#newcode1088 include/core/SkPaint.h:1088: const SkData* getDescriptor(const SkDeviceProperties* deviceProperties, const SkMatrix*, This name ...
5 years, 9 months ago (2015-03-13 14:48:30 UTC) #6
joshualitt
On 2015/03/13 14:48:30, bungeman1 wrote: > https://codereview.chromium.org/1005103003/diff/20001/include/core/SkPaint.h > File include/core/SkPaint.h (right): > > https://codereview.chromium.org/1005103003/diff/20001/include/core/SkPaint.h#newcode1088 > ...
5 years, 9 months ago (2015-03-13 14:56:26 UTC) #7
reed1
api lgtm
5 years, 9 months ago (2015-03-13 15:15:19 UTC) #9
bungeman-skia
Why not? lgtm
5 years, 9 months ago (2015-03-13 15:28:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005103003/20002
5 years, 9 months ago (2015-03-13 15:32:45 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 15:38:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:20002) as
https://skia.googlesource.com/skia/+/fd45079314b739979492601fc7a242aff24c58a3

Powered by Google App Engine
This is Rietveld 408576698