Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Issue 1005053004: Debugger: remove unused JS Debugger API. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: remove unused JS Debugger API. R=ulan@chromium.org Committed: https://crrev.com/46cc8740a9269ee4eb7edd473e295fe67bfddc8f Cr-Commit-Position: refs/heads/master@{#27464}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -88 lines) Patch
M src/debug-debugger.js View 1 4 chunks +2 lines, -23 lines 0 comments Download
M src/runtime/runtime.h View 1 4 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 3 chunks +7 lines, -47 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M test/mjsunit/debug-liveedit-check-stack.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/debug-set-variable-value.js View 2 chunks +8 lines, -7 lines 0 comments Download
M test/mjsunit/es6/generators-debug-liveedit.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-330046.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-385002.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 9 months ago (2015-03-24 15:38:03 UTC) #1
Yang
On 2015/03/24 15:38:03, Yang wrote: ping
5 years, 9 months ago (2015-03-25 12:01:03 UTC) #2
ulan
lgtm
5 years, 9 months ago (2015-03-25 12:09:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1005053004/20001
5 years, 9 months ago (2015-03-26 08:07:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 08:15:36 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 08:15:51 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/46cc8740a9269ee4eb7edd473e295fe67bfddc8f
Cr-Commit-Position: refs/heads/master@{#27464}

Powered by Google App Engine
This is Rietveld 408576698