Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 1004993004: [turbofan] Fix bug in OSR deconstruction. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix bug in OSR deconstruction. In constructing the transfer between loop copies, we need to merge the backedges from all the previous copies of the given loop. The control reduction will work out which ones are really reachable. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/434d1ad0146d63120b26938983fa6b1606c3e7a7 Cr-Commit-Position: refs/heads/master@{#27246}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+357 lines, -42 lines) Patch
M src/compiler/opcodes.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/compiler/osr.cc View 1 2 3 4 4 chunks +116 lines, -38 lines 0 comments Download
M src/runtime/runtime.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M test/cctest/compiler/test-osr.cc View 1 2 2 chunks +104 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-infinite.js View 1 chunk +78 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-labeled.js View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
titzer
5 years, 9 months ago (2015-03-17 15:59:21 UTC) #1
Michael Starzinger
LGTM. https://codereview.chromium.org/1004993004/diff/60001/src/compiler/osr.cc File src/compiler/osr.cc (right): https://codereview.chromium.org/1004993004/diff/60001/src/compiler/osr.cc#newcode36 src/compiler/osr.cc:36: if (TRACE_COND) do { \ nit: Shouldn't the ...
5 years, 9 months ago (2015-03-17 16:30:04 UTC) #2
titzer
https://codereview.chromium.org/1004993004/diff/60001/src/compiler/osr.cc File src/compiler/osr.cc (right): https://codereview.chromium.org/1004993004/diff/60001/src/compiler/osr.cc#newcode36 src/compiler/osr.cc:36: if (TRACE_COND) do { \ On 2015/03/17 16:30:04, Michael ...
5 years, 9 months ago (2015-03-17 16:41:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004993004/80001
5 years, 9 months ago (2015-03-17 16:43:27 UTC) #6
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-17 17:55:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 17:55:35 UTC) #8
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/434d1ad0146d63120b26938983fa6b1606c3e7a7
Cr-Commit-Position: refs/heads/master@{#27246}

Powered by Google App Engine
This is Rietveld 408576698