Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: client/crash_report_database_win.cc

Issue 1004913004: win: Add UUID::InitializeFromSystemUUID() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/misc/uuid.h » ('j') | util/misc/uuid_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crash_report_database_win.cc
diff --git a/client/crash_report_database_win.cc b/client/crash_report_database_win.cc
index afa39338fd71c9f81257a2df5d692a33d6dc2d57..4a32f492f36b5568d128b4c0ed754d3ff5cb2a85 100644
--- a/client/crash_report_database_win.cc
+++ b/client/crash_report_database_win.cc
@@ -584,9 +584,8 @@ OperationStatus CrashReportDatabaseWin::PrepareNewCrashReport(
::UUID system_uuid;
if (UuidCreate(&system_uuid) != RPC_S_OK)
return kFileSystemError;
- static_assert(sizeof(system_uuid) == 16, "unexpected system uuid size");
- static_assert(offsetof(::UUID, Data1) == 0, "unexpected uuid layout");
- UUID uuid(reinterpret_cast<const uint8_t*>(&system_uuid.Data1));
+ UUID uuid;
+ uuid.InitializeFromSystemUUID(&system_uuid);
scoped_ptr<NewReportDisk> new_report(new NewReportDisk());
new_report->uuid = uuid;
« no previous file with comments | « no previous file | util/misc/uuid.h » ('j') | util/misc/uuid_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698