Descriptionwin: Add UUID::InitializeFromSystemUUID().
The new call is also used in
CrashReportDatabaseWin::PrepareNewCrashReport(). Previously, that method
used the UUID::InitializeFromBytes() constructor. That actually caused
various fields of the UUID to be byte-swapped so that the ::UUID and
crashpad::UUID would be different UUIDs. Although a UUID is mostly
random, the version field in data_3 is used as a namespace and should be
4 for random UUIDs, and this was not the case under swapping.
TEST=crashpad_util_test UUID.FromSystem
BUG=crashpad:1
R=scottmg@chromium.org
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/e7b80a52f5b9832814485b58f66d4b13117a5186
Patch Set 1 #Patch Set 2 : #
Total comments: 1
Patch Set 3 : Address review feedback #Patch Set 4 : Rebase #
Messages
Total messages: 6 (1 generated)
|