Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 1004913003: ServiceWorker: Don't start the timeout timer when DevTools is detached (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index c5b2dcc04a0ce694a62dbc70a1a94bfabaa72d96..2fba41ae758bdf4eaaa5de678cb786e135c9bb59 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -438,6 +438,35 @@ TEST_F(ServiceWorkerVersionTest, ListenerAvailability) {
EXPECT_TRUE(version_->cache_listener_.get());
}
+TEST_F(ServiceWorkerVersionTest, SetDevToolsAttached) {
+ ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_FAILED;
+ version_->StartWorker(CreateReceiverOnCurrentThread(&status));
+
+ ASSERT_EQ(ServiceWorkerVersion::STARTING, version_->running_status());
+
+ ASSERT_TRUE(version_->timeout_timer_.IsRunning());
+ ASSERT_FALSE(version_->start_time_.is_null());
+ ASSERT_FALSE(version_->skip_recording_startup_time_);
+
+ // Simulate DevTools is attached. This should deactivate the timer for start
+ // timeout, but not stop the timer itself.
+ version_->SetDevToolsAttached(true);
+ EXPECT_TRUE(version_->timeout_timer_.IsRunning());
+ EXPECT_TRUE(version_->start_time_.is_null());
+ EXPECT_TRUE(version_->skip_recording_startup_time_);
+
+ // Simulate DevTools is detached. This should reactivate the timer for start
+ // timeout.
+ version_->SetDevToolsAttached(false);
+ EXPECT_TRUE(version_->timeout_timer_.IsRunning());
+ EXPECT_FALSE(version_->start_time_.is_null());
+ EXPECT_TRUE(version_->skip_recording_startup_time_);
+
+ base::RunLoop().RunUntilIdle();
+ EXPECT_EQ(SERVICE_WORKER_OK, status);
+ EXPECT_EQ(ServiceWorkerVersion::RUNNING, version_->running_status());
+}
+
TEST_F(ServiceWorkerFailToStartTest, RendererCrash) {
ServiceWorkerStatusCode status = SERVICE_WORKER_ERROR_NETWORK; // dummy value
version_->StartWorker(

Powered by Google App Engine
This is Rietveld 408576698