Use requestMediaKeySystemAccess() to check type support in EME layout tests

Use requestMediaKeySystemAccess() to check type support in EME layout tests

BUG=441585
TEST=updated tests pass

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192054

[jrummell, 2015-03-12 22:45:16]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, sandersd@chromium.org

[jrummell, 2015-03-12 22:45:16]

PTAL. You should probably start with the last file (encrypted-media-utils.js)
and then work backwards (all the other files have the same pattern except
encrypted-media-syntax.html which is second last).

[ddorwin, 2015-03-12 23:18:08]

I looked at the JS and one of the tests. LG overall. deferring to sandersd for
full review.

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
File LayoutTests/media/encrypted-media/encrypted-media-utils.js (right):

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:17: // For now,
assume that implementations that support a container type for clear
This comment is obsolete.

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:28: function
getInitDataType()
getSupported...

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:32: return 'webm';
Does this end up being a promise resolved with 'webm'? Should we be more
explicit for readability? sandersd?

[jrummell, 2015-03-13 18:05:31]

Updated.

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
File LayoutTests/media/encrypted-media/encrypted-media-utils.js (right):

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:17: // For now,
assume that implementations that support a container type for clear
On 2015/03/12 23:18:08, ddorwin wrote:
> This comment is obsolete.

Done.

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:28: function
getInitDataType()
On 2015/03/12 23:18:08, ddorwin wrote:
> getSupported...

Done.

https://codereview.chromium.org/1004843003/diff/1/LayoutTests/media/encrypted...
LayoutTests/media/encrypted-media/encrypted-media-utils.js:32: return 'webm';
On 2015/03/12 23:18:08, ddorwin wrote:
> Does this end up being a promise resolved with 'webm'? Should we be more
> explicit for readability? sandersd?

Done.

[sandersd (OOO until July 31), 2015-03-16 19:57:08]

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
File LayoutTests/media/encrypted-media/encrypted-media-events.html (right):

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-events.html:54: return
mediaKeySession.generateRequest(initDataType, getInitData(initDataType));
Why not the usual pattern of fetching this after getSupportedInitDataType()?

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
File
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html
(right):

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html:62:
initDataType = type;
Missing declarations.

[jrummell, 2015-03-16 20:44:09]

Updated.

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
File LayoutTests/media/encrypted-media/encrypted-media-events.html (right):

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-events.html:54: return
mediaKeySession.generateRequest(initDataType, getInitData(initDataType));
On 2015/03/16 19:57:08, sandersd wrote:
> Why not the usual pattern of fetching this after getSupportedInitDataType()?

Probably the first file I changed. Done.

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
File
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html
(right):

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html:62:
initDataType = type;
On 2015/03/16 19:57:08, sandersd wrote:
> Missing declarations.

Done. Wonder how it works?

[sandersd (OOO until July 31), 2015-03-17 22:23:17]

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
File
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html
(right):

https://codereview.chromium.org/1004843003/diff/20001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html:62:
initDataType = type;
On 2015/03/16 20:44:09, jrummell wrote:
> On 2015/03/16 19:57:08, sandersd wrote:
> > Missing declarations.
> 
> Done. Wonder how it works?

By setting those values on the global object (aka window).

https://codereview.chromium.org/1004843003/diff/40001/LayoutTests/media/encry...
File
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html
(right):

https://codereview.chromium.org/1004843003/diff/40001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html:12:
var initDataType;
Now that I'm thinking about it, this should all be inside a function, otherwise
these vars are on the global object too.

The usual syntax is:

  (function(){

  // declarations and code

  )();

[jrummell, 2015-03-17 23:49:13]

Updated.

https://codereview.chromium.org/1004843003/diff/40001/LayoutTests/media/encry...
File
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html
(right):

https://codereview.chromium.org/1004843003/diff/40001/LayoutTests/media/encry...
LayoutTests/media/encrypted-media/encrypted-media-keystatuses-multiple-updates.html:12:
var initDataType;
On 2015/03/17 22:23:17, sandersd wrote:
> Now that I'm thinking about it, this should all be inside a function,
otherwise
> these vars are on the global object too.
> 
> The usual syntax is:
> 
>   (function(){
> 
>   // declarations and code
> 
>   )();
> 

Moved inside the test.

[sandersd (OOO until July 31), 2015-03-18 00:12:33]

lgtm

[jrummell, 2015-03-18 00:14:10]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2015-03-18 00:14:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004843003/60001

[commit-bot: I haz the power, 2015-03-18 01:52:06]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192054