Issue 100483003: Disable getenv() in libjpeg and libjpeg_turbo (roll to 238232)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 100483003: Disable getenv() in libjpeg and libjpeg_turbo (roll to 238232) (Closed)

Created:
7 years ago by Xianzhu

Modified:
7 years ago

Reviewers:
cpu_(ooo_6.6-7.5), Noel Gordon

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Disable getenv() in libjpeg and libjpeg_turbo (roll to 238232) getenv() is used in libjpeg and libjpeg_turbo to get environment variable JPEGMEM which overrides the default max_memory setting from jpeg_mem_init. However, getenv() is not thread-safe. Now libjpeg may be called from multiple threads when impl-side-painting is enabled. BUG=322228 TBR=cpu Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238278

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/libjpeg/libjpeg.gyp	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/100483003/1

7 years ago (2013-12-03 00:19:36 UTC) #3

Message was sent while issue was closed.

Change committed as 238278

Expand Messages | Collapse Messages