Pepper: Cache the document URL in PepperPluginInstanceImpl

Pepper: Cache the document URL in PepperPluginInstanceImpl

BUG=465765
Committed: https://crrev.com/20f19eb905b8224ab7f72dc56285470b3500daff
Cr-Commit-Position: refs/heads/master@{#321240}

[dmichael (off chromium), 2015-03-18 19:53:46]

dmichael@chromium.org changed reviewers:
+ bbudge@chromium.org

[bbudge, 2015-03-18 21:02:36]

LGTM
Good luck!

https://codereview.chromium.org/1004803007/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/1004803007/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_plugin_instance_impl.cc:568:
container_->element().document().url(),
You could use document_url_ here. The comment on line 535 makes me wonder if you
should initialize document_url_ later.

[dmichael (off chromium), 2015-03-18 21:54:58]

The CQ bit was checked by dmichael@chromium.org

[commit-bot: I haz the power, 2015-03-18 21:55:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004803007/40001

[dmichael (off chromium), 2015-03-18 21:55:15]

The CQ bit was unchecked by dmichael@chromium.org

[dmichael (off chromium), 2015-03-18 21:57:00]

The CQ bit was checked by dmichael@chromium.org

[dmichael (off chromium), 2015-03-18 21:57:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bbudge@chromium.org
Link to the patchset: https://codereview.chromium.org/1004803007/#ps60001
(title: "review comments")

[commit-bot: I haz the power, 2015-03-18 21:57:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004803007/60001

[dmichael (off chromium), 2015-03-18 21:57:23]

Thanks!

https://codereview.chromium.org/1004803007/diff/20001/content/renderer/pepper...
File content/renderer/pepper/pepper_plugin_instance_impl.cc (right):

https://codereview.chromium.org/1004803007/diff/20001/content/renderer/pepper...
content/renderer/pepper/pepper_plugin_instance_impl.cc:568:
container_->element().document().url(),
On 2015/03/18 21:02:36, bbudge wrote:
> You could use document_url_ here.
Done, thanks.

> The comment on line 535 makes me wonder if you
> should initialize document_url_ later.
The WebContainer shouldn't be affected by a NULL render_frame etc, unless I'm
misunderstanding.

[commit-bot: I haz the power, 2015-03-19 00:01:33]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-19 00:02:18]

Patchset 4 (id:??) landed as
https://crrev.com/20f19eb905b8224ab7f72dc56285470b3500daff
Cr-Commit-Position: refs/heads/master@{#321240}