Source/modules/accessibility/AXObjectCacheImpl.cpp - Issue 1004803004: Add handling to respect role attribute in AXObjects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXObjectCacheImpl.cpp

Issue 1004803004: Add handling to respect role attribute in AXObjects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXObjectCacheImpl.cpp

diff --git a/Source/modules/accessibility/AXObjectCacheImpl.cpp b/Source/modules/accessibility/AXObjectCacheImpl.cpp

index 48f739ff499886ff54bb0b67ad913b4537a521c8..47e682327e3cefda1c7c49d26d45ac68e9ec2e56 100644

--- a/Source/modules/accessibility/AXObjectCacheImpl.cpp

+++ b/Source/modules/accessibility/AXObjectCacheImpl.cpp

@@ -259,8 +259,8 @@ PassRefPtr<AXObject> AXObjectCacheImpl::createFromRenderer(LayoutObject* layoutO

// If the node is aria role="list" or the aria role is empty and its a

// ul/ol/dl type (it shouldn't be a list if aria says otherwise).

- if (node && ((nodeHasRole(node, "list") || nodeHasRole(node, "directory"))

- || (nodeHasRole(node, nullAtom) && (isHTMLUListElement(*node) || isHTMLOListElement(*node) || isHTMLDListElement(*node)))))

+ if (nodeHasRole(node, "list") || nodeHasRole(node, "directory")

+ || (nodeHasRole(node, nullAtom) && (isHTMLUListElement(node) || isHTMLOListElement(node) || isHTMLDListElement(node))))

return AXList::create(layoutObject, this);

// aria tables

« no previous file with comments | « Source/modules/accessibility/AXMenuList.cpp ('k') | Source/modules/accessibility/AXProgressIndicator.h » ('j') | no next file with comments »