Source/modules/accessibility/AXMenuList.h - Issue 1004803004: Add handling to respect role attribute in AXObjects.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/accessibility/AXMenuList.h

Issue 1004803004: Add handling to respect role attribute in AXObjects. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/modules/accessibility/AXListBoxOption.cpp ('k') | Source/modules/accessibility/AXMenuList.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.	2 * Copyright (C) 2010 Apple Inc. All Rights Reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 29 matching lines...) Expand all Loading...
40 virtual bool isCollapsed() const override;	40 virtual bool isCollapsed() const override;

41 virtual AccessibilityExpanded isExpanded() const override final;	41 virtual AccessibilityExpanded isExpanded() const override final;

42 virtual bool press() const override;	42 virtual bool press() const override;

43	43

44 void didUpdateActiveOption(int optionIndex);	44 void didUpdateActiveOption(int optionIndex);

45	45

46 private:	46 private:

47 AXMenuList(LayoutMenuList, AXObjectCacheImpl);	47 AXMenuList(LayoutMenuList, AXObjectCacheImpl);

48	48

49 virtual bool isMenuList() const override { return true; }	49 virtual bool isMenuList() const override { return true; }

50 virtual AccessibilityRole roleValue() const override { return PopUpButtonRol e; }	50 virtual AccessibilityRole roleValue() const override;

51 virtual bool canSetFocusAttribute() const override;	51 virtual bool canSetFocusAttribute() const override;

52	52

53 virtual void addChildren() override;	53 virtual void addChildren() override;

54 virtual void childrenChanged() override;	54 virtual void childrenChanged() override;

55 };	55 };

56	56

57 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuList, isMenuList());	57 DEFINE_AX_OBJECT_TYPE_CASTS(AXMenuList, isMenuList());

58	58

59 } // namespace blink	59 } // namespace blink

60	60

61 #endif // AXMenuList_h	61 #endif // AXMenuList_h

OLD	NEW