Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1004803002: [Win] Cleanup: The BrowserFrameView doesn't need to listen to profile name changes. (Closed)

Created:
5 years, 9 months ago by noms (inactive)
Modified:
5 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] Cleanup: The BrowserFrameView doesn't need to listen to profile name changes. In the case on the new avatar button, the UpdateAvatar...() methods just updates the visibility of the button, not its contents, and the visibility doesn't depend on the name. I've also tried to name the methods a little more consistently. There's a giant refactor that needs to be done to rename avatar_button to avatar_icon and new_avatar_button to avatar_button, but this isn't that. BUG=466692 Committed: https://crrev.com/215dcf63d9140d8fb25efe81afe169b766d5b4a2 Cr-Commit-Position: refs/heads/master@{#322057}

Patch Set 1 : #

Messages

Total messages: 11 (6 generated)
noms (inactive)
5 years, 9 months ago (2015-03-24 18:24:33 UTC) #6
sky
LGTM
5 years, 9 months ago (2015-03-24 19:26:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004803002/80001
5 years, 9 months ago (2015-03-24 19:31:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:80001)
5 years, 9 months ago (2015-03-24 20:10:40 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 20:11:34 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/215dcf63d9140d8fb25efe81afe169b766d5b4a2
Cr-Commit-Position: refs/heads/master@{#322057}

Powered by Google App Engine
This is Rietveld 408576698