Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1004733012: Deprecate CSSKeyframesRule.insertRule() (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
Timothy Loh
CC:
blink-reviews, rwlbuis, ed+blinkwatch_opera.com, shans, rjwright, Mike Lawther (Google), blink-reviews-animation_chromium.org, blink-reviews-css, vivekg_samsung, vivekg, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, Inactive, darktears, arv+blink, Steve Block, Eric Willigers
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M LayoutTests/animations/change-keyframes-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/keyframes-cssom-prefixed-02-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/keyframes-cssom-unprefixed-02-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/keyframes-missing-arguments-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/keyframes-rule-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/css/shared-stylesheet-mutation-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSKeyframesRule.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
philipj_slow
PTAL
5 years, 9 months ago (2015-03-26 04:09:52 UTC) #2
Timothy Loh
lgtm
5 years, 9 months ago (2015-03-26 04:12:10 UTC) #3
philipj_slow
update test expectations
5 years, 9 months ago (2015-03-26 05:30:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004733012/20001
5 years, 9 months ago (2015-03-26 05:31:34 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 09:17:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192590

Powered by Google App Engine
This is Rietveld 408576698