Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1236)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 100473010: Adding RenderWidgetHostViewChildFrame for OOPIF view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: WIP snapshot with major comment rewrite. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 2822724adfae45a5a56fc078e29376f9ccae6e47..305dfd1a06894e214da4cbba3972d1cc9fcf11ff 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -19,6 +19,7 @@ class FilePath;
namespace content {
+class CrossProcessFrameConnector;
class FrameTree;
class FrameTreeNode;
class RenderFrameHostDelegate;
@@ -51,6 +52,9 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {
RenderViewHostImpl* render_view_host() { return render_view_host_; }
RenderFrameHostDelegate* delegate() { return delegate_; }
+ void SetCrossProcessFrameConnector(
Charlie Reis 2013/12/17 01:09:31 It feels odd to me to have no comments on the publ
awong 2013/12/17 02:45:27 Done.
+ CrossProcessFrameConnector* cross_process_frame_connector);
+
protected:
friend class RenderFrameHostFactory;
@@ -81,6 +85,19 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {
RenderFrameHostDelegate* delegate_;
+ // |cross_process_frame_connector_| passes messages from an out-of-process
+ // child frame to the parent frame.
+ //
+ // This is only non-NULL when the RenderFrameHost object is
+ // (a) swapped out
+ // (b) has a child frame that
nasko 2013/12/17 00:56:52 This doesn't end properly, nor does it read cohere
awong 2013/12/17 02:45:27 Yep...sorry...I hadn't gotten this far yet.
+ // Object that handles messages destined to a child frame in another
+ // process from its parent. Non-NULL only when this RenderFrameHost is
+ // swapped out and corresponds to a direct child frame of a frame in its
+ // renderer process.
+ // This will move to RenderFrameProxyHost when that class is created.
+ CrossProcessFrameConnector* cross_process_frame_connector_;
+
// Reference to the whole frame tree that this RenderFrameHost belongs too.
// Allows this RenderFrameHost to add and remove nodes in response to
// messages from the renderer requesting DOM manipulation.

Powered by Google App Engine
This is Rietveld 408576698