Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: content/browser/frame_host/cross_process_frame_connector.h

Issue 100473010: Adding RenderWidgetHostViewChildFrame for OOPIF view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: constructor rated explicit Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/cross_process_frame_connector.h
diff --git a/content/browser/frame_host/cross_process_frame_connector.h b/content/browser/frame_host/cross_process_frame_connector.h
new file mode 100644
index 0000000000000000000000000000000000000000..6c43dca595f91f3c2eb7645d8c4367d7f4ab8655
--- /dev/null
+++ b/content/browser/frame_host/cross_process_frame_connector.h
@@ -0,0 +1,103 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_
+#define CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_
+
+#include "cc/output/compositor_frame.h"
+#include "ui/gfx/rect.h"
+
+namespace IPC {
+class Message;
+}
+
+struct FrameHostMsg_BuffersSwappedACK_Params;
+struct GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params;
+
+namespace content {
+class RenderFrameHostImpl;
+class RenderWidgetHostImpl;
+class RenderWidgetHostViewChildFrame;
+
+// CrossProcessFrameConnector provides the platform view abstraction for
+// RenderWidgetHostViewChildFrame allowing RWHVChildFrame to remain ignorant
+// of RenderFrameHost.
+//
+// The RenderWidgetHostView of an out-of-process child frame needs to
+// communicate with the swapped out RenderFrameHost representing this frame
+// in the process of the parent frame. For example, assume you have this page:
+//
+// -----------------
+// | frame 1 |
+// | ----------- |
+// | | frame 2 | |
+// | ----------- |
+// -----------------
+//
+// If frames 1 and 2 are in process A and B, there are 4 RenderFrameHosts:
+// A1 - RFH for frame 1 in process A
+// B1 - Swapped out RFH for frame 1 in process B
+// A2 - Swapped out RFH for frame 2 in process A
+// B2 - RFH for frame 2 in process B
+//
+// B2, having a parent frame in a diferent process, will have a
+// RenderWidgetHostViewChildFrame. This RenderWidgetHostViewChildFrame needs
+// to communicate with A2 so that the painting logic in process A can
+// composite B2's data with A1's. CrossProcessFrameConnector bridges between
+// B2's RenderWidgetHostViewChildFrame and A2 to allow for this communication.
+// (Note: B1 is only mentioned for completeness. It is not needed in this
+// example.)
+//
+// CrossProcessFrameConnector objects are owned by the child frame's
+// RenderFrameHostManager. When a child frame swaps, SetChildFrameView() is
+// called to update to the new view.
+//
+// TODO(kenrb): Double-check this comment's accuracy.
+class CrossProcessFrameConnector {
+ public:
+ // |frame_proxy_in_parent_renderer| corresponds to A2 in the example above.
+ explicit CrossProcessFrameConnector(
+ RenderFrameHostImpl* frame_proxy_in_parent_renderer);
+ virtual ~CrossProcessFrameConnector();
+
+ bool OnMessageReceived(const IPC::Message &msg);
+
+ // |view| corresponds to B2's RenderWidgetHostViewChildFrame in the example
+ // above.
+ void SetView(RenderWidgetHostViewChildFrame* view);
+
+ // 'Platform' functionality exposed to RenderWidgetHostViewChildFrame.
+ // These methods can forward messages to the child frame proxy in the parent
+ // frame renderer or attempt to handle them within the browser process.
+ void ChildFrameBuffersSwapped(
+ const GpuHostMsg_AcceleratedSurfaceBuffersSwapped_Params& params,
+ int gpu_host_id);
+
+ void ChildFrameCompositorFrameSwapped(
+ uint32 output_surface_id,
+ scoped_ptr<cc::CompositorFrame> frame);
+
+ gfx::Rect ChildFrameRect();
+
+ private:
+ // Handlers for messages received from the parent frame.
+ void OnBuffersSwappedACK(
+ const FrameHostMsg_BuffersSwappedACK_Params& params);
+
+ // The RenderFrameHost that routes messages to the parent frame's renderer
+ // process.
+ // TODO(kenrb): The type becomes RenderFrameProxyHost when that class comes
+ // to exist.
+ RenderFrameHostImpl* frame_proxy_in_parent_renderer_;
+
+ // The RenderWidgetHostView for the frame. Initially NULL.
+ RenderWidgetHostViewChildFrame* view_;
+
+ gfx::Rect child_frame_rect_;
+};
+
+} // namespace content
+
+#endif // CONTENT_BROWSER_FRAME_HOST_CROSS_PROCESS_FRAME_CONNECTOR_H_
+

Powered by Google App Engine
This is Rietveld 408576698