Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: content/common/frame_messages.h

Issue 100473010: Adding RenderWidgetHostViewChildFrame for OOPIF view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Tweaked a comment Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for interacting with frames. 5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include "cc/output/begin_frame_args.h"
9 #include "cc/output/compositor_frame.h"
10 #include "cc/output/compositor_frame_ack.h"
8 #include "content/common/content_export.h" 11 #include "content/common/content_export.h"
9 #include "content/public/common/common_param_traits.h" 12 #include "content/public/common/common_param_traits.h"
10 #include "ipc/ipc_message_macros.h" 13 #include "ipc/ipc_message_macros.h"
14 #include "url/gurl.h"
11 15
12 #undef IPC_MESSAGE_EXPORT 16 #undef IPC_MESSAGE_EXPORT
13 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT 17 #define IPC_MESSAGE_EXPORT CONTENT_EXPORT
14 18
15 #define IPC_MESSAGE_START FrameMsgStart 19 #define IPC_MESSAGE_START FrameMsgStart
16 20
21 // -----------------------------------------------------------------------------
22 // Messages sent from the browser to the renderer.
23
24 // When HW accelerated buffers are swapped in an out of process child frame
25 // renderer, the message is forwarded to the top level frame renderer to
26 // notify it of a new texture available for compositing.
27 IPC_MESSAGE_ROUTED4(FrameMsg_ChildFrameBuffersSwapped,
28 gfx::Size /* size */,
29 std::string /* mailbox_name */,
30 int /* route_id */,
piman 2013/12/17 00:14:57 route_id of what? How does that relate to the impl
awong 2013/12/17 02:45:27 Ooh...good catch. It's the gpu_route_id. Comes fr
31 int /* gpu_host_id */)
piman 2013/12/17 00:14:57 2 things about these messages: 1- I don't see the
awong 2013/12/17 02:45:27 This is part 1 of a set of CLs that are being upst
32
33 IPC_MESSAGE_ROUTED4(FrameMsg_ChildFrameCompositorFrameSwapped,
34 cc::CompositorFrame /* frame */,
35 int /* route_id */,
36 uint32 /* output_surface_id */,
37 int /* renderer_host_id */)
38
39 // -----------------------------------------------------------------------------
40 // Messages sent from the renderer to the browser.
41
17 // Sent by the renderer when a child frame is created in the renderer. The 42 // Sent by the renderer when a child frame is created in the renderer. The
18 // |parent_frame_id| and |frame_id| are NOT routing ids. They are 43 // |parent_frame_id| and |frame_id| are NOT routing ids. They are
19 // renderer-allocated identifiers used for tracking a frame's creation. 44 // renderer-allocated identifiers used for tracking a frame's creation.
20 // 45 //
21 // Each of these messages will have a corresponding FrameHostMsg_Detach message 46 // Each of these messages will have a corresponding FrameHostMsg_Detach message
22 // sent when the frame is detached from the DOM. 47 // sent when the frame is detached from the DOM.
23 // 48 //
24 // TOOD(ajwong): replace parent_render_frame_id and frame_id with just the 49 // TOOD(ajwong): replace parent_render_frame_id and frame_id with just the
25 // routing ids. 50 // routing ids.
26 IPC_SYNC_MESSAGE_CONTROL4_1(FrameHostMsg_CreateChildFrame, 51 IPC_SYNC_MESSAGE_CONTROL4_1(FrameHostMsg_CreateChildFrame,
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 // create a plugin. The browser will create the plugin process if 103 // create a plugin. The browser will create the plugin process if
79 // necessary, and will return a handle to the channel on success. 104 // necessary, and will return a handle to the channel on success.
80 // On error an empty string is returned. 105 // On error an empty string is returned.
81 IPC_SYNC_MESSAGE_CONTROL4_2(FrameHostMsg_OpenChannelToPlugin, 106 IPC_SYNC_MESSAGE_CONTROL4_2(FrameHostMsg_OpenChannelToPlugin,
82 int /* render_frame_id */, 107 int /* render_frame_id */,
83 GURL /* url */, 108 GURL /* url */,
84 GURL /* page_url */, 109 GURL /* page_url */,
85 std::string /* mime_type */, 110 std::string /* mime_type */,
86 IPC::ChannelHandle /* channel_handle */, 111 IPC::ChannelHandle /* channel_handle */,
87 content::WebPluginInfo /* info */) 112 content::WebPluginInfo /* info */)
113
nasko 2013/12/16 23:16:32 nit: just one empty line
awong 2013/12/17 02:45:27 Done.
114
115 // Acknowledge that we presented a HW buffer and provide a sync point
116 // to specify the location in the command stream when the compositor
117 // is no longer using it.
118 IPC_MESSAGE_ROUTED4(FrameHostMsg_BuffersSwappedACK,
119 std::string /* mailbox_name */,
120 int /* route_id */,
121 int /* gpu_host_id */,
122 uint32 /* sync_point */)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698