Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: Source/bindings/scripts/unstable/v8_interface.py

Issue 100473006: IDL compiler: [Constructor] w/o arguments (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/unstable/v8_interface.py
diff --git a/Source/bindings/scripts/unstable/v8_interface.py b/Source/bindings/scripts/unstable/v8_interface.py
index af6152919294ef0ef6d12244c9610c52a7328100..82d00d69eb1a5c98f381f57bb4dca8d794da0355 100644
--- a/Source/bindings/scripts/unstable/v8_interface.py
+++ b/Source/bindings/scripts/unstable/v8_interface.py
@@ -72,6 +72,12 @@ def generate_interface(interface):
'bindings/v8/ExceptionMessages.h',
'bindings/v8/ExceptionState.h'])
+ # [Constructor]
+ has_constructor = 'Constructor' in extended_attributes
+ if has_constructor:
+ includes.update(['bindings/v8/ExceptionMessages.h',
haraken 2013/12/05 05:54:16 How about including ExceptionMessages.h always? It
Nils Barth (inactive) 2013/12/05 06:09:20 We include it about 45% of the time (~300/680), so
+ 'bindings/v8/V8ObjectConstructor.h'])
+
# [GenerateVisitDOMWrapper]
generate_visit_dom_wrapper_function = extended_attributes.get('GenerateVisitDOMWrapper')
if generate_visit_dom_wrapper_function:
@@ -90,6 +96,7 @@ def generate_interface(interface):
'conditional_string': conditional_string(interface), # [Conditional]
'cpp_class': cpp_name(interface),
'generate_visit_dom_wrapper_function': generate_visit_dom_wrapper_function,
+ 'has_constructor': has_constructor,
'has_custom_legacy_call': 'CustomLegacyCall' in extended_attributes, # [CustomLegacyCall]
'has_custom_to_v8': 'CustomToV8' in extended_attributes, # [CustomToV8]
'has_custom_wrap': 'CustomWrap' in extended_attributes, # [CustomWrap]

Powered by Google App Engine
This is Rietveld 408576698