Issue 100473006: IDL compiler: [Constructor] w/o arguments

Issue 100473006: IDL compiler: [Constructor] w/o arguments (Closed)

Created:
7 years ago by Nils Barth (inactive)

Modified:
7 years ago

Reviewers:
haraken

CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

IDL compiler: [Constructor] w/o arguments Initial actual [Constructor] CL: implements constructor w/o arguments. * Also fixes some inconsistent and excessive line breaks in Perl. BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163316

Patch Set 1 #

Total comments: 5

Patch Set 2 : Synced to changes #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -14 lines)			Patch
M	Source/bindings/scripts/code_generator_v8.pm	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download
M	Source/bindings/scripts/unstable/v8_interface.py	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	Source/bindings/templates/interface.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/bindings/templates/interface.cpp	View	1	2 chunks	+45 lines, -0 lines	0 comments	Download
M	Source/bindings/templates/interface_base.cpp	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestInterface.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestInterfaceConstructor.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestNode.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestObject.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestOverloadedConstructors.cpp	View	1	4 chunks	+0 lines, -4 lines	0 comments	Download
M	Source/bindings/tests/results/V8TestTypedefs.cpp	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/100473006/diff/1/Source/bindings/scripts/unstable/v8_interface.py File Source/bindings/scripts/unstable/v8_interface.py (right): https://codereview.chromium.org/100473006/diff/1/Source/bindings/scripts/unstable/v8_interface.py#newcode78 Source/bindings/scripts/unstable/v8_interface.py:78: includes.update(['bindings/v8/ExceptionMessages.h', How about including ExceptionMessages.h always? It looks ...

7 years ago (2013-12-05 05:54:16 UTC) #2

Nils Barth (inactive)

Thanks; two followup CLs to do! https://codereview.chromium.org/100473006/diff/1/Source/bindings/scripts/unstable/v8_interface.py File Source/bindings/scripts/unstable/v8_interface.py (right): https://codereview.chromium.org/100473006/diff/1/Source/bindings/scripts/unstable/v8_interface.py#newcode78 Source/bindings/scripts/unstable/v8_interface.py:78: includes.update(['bindings/v8/ExceptionMessages.h', On 2013/12/05 ...

7 years ago (2013-12-05 06:09:19 UTC) #3

Nils Barth (inactive)

Followups done and landed, synced to incorporate changes, so committing.

7 years ago (2013-12-06 02:17:10 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/100473006/20001

7 years ago (2013-12-06 02:17:45 UTC) #5

Message was sent while issue was closed.

Change committed as 163316

Expand Messages | Collapse Messages