Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 1004703002: Have DM and nanobench display times in minutes when they're above 60 seconds. (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
borenet, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have DM and nanobench display times in minutes when they're above 60 seconds. Getting tired of trying to divide in my head when reading Valgrind logs. BUG=skia: Committed: https://skia.googlesource.com/skia/+/d1f7f990a126ec5d3ca3efefe9d27a36f68272ab

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/timer/Timer.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 9 months ago (2015-03-12 14:59:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004703002/20001
5 years, 9 months ago (2015-03-12 15:00:05 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-12 15:00:06 UTC) #5
borenet
LGTM
5 years, 9 months ago (2015-03-12 17:29:06 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 17:29:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d1f7f990a126ec5d3ca3efefe9d27a36f68272ab

Powered by Google App Engine
This is Rietveld 408576698