Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 1004693002: Add #include first in Sk4x_* files (Closed)

Created:
5 years, 9 months ago by rmistry
Modified:
5 years, 9 months ago
Reviewers:
mtklein
CC:
reviews_skia.org, scroggo
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/core/Sk4x_neon.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/Sk4x_portable.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/core/Sk4x_sse.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmistry
Background: Leon and I spoke about these files. They are correct and do not cause ...
5 years, 9 months ago (2015-03-12 14:02:08 UTC) #2
mtklein
lgtm
5 years, 9 months ago (2015-03-12 14:03:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004693002/1
5 years, 9 months ago (2015-03-12 14:03:13 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 14:09:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f93dd488d575b5d9448228e6516cbe01c474bdf6

Powered by Google App Engine
This is Rietveld 408576698