tests/compiler/dart2js/backend_dart/sexpr_test.dart - Issue 1004683002: Refactor IrBuilder to use SemanticVisitor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/backend_dart/sexpr_test.dart

Issue 1004683002: Refactor IrBuilder to use SemanticVisitor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Handle local/static constants and index prefix/postfix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/backend_dart/sexpr_test.dart

diff --git a/tests/compiler/dart2js/backend_dart/sexpr_test.dart b/tests/compiler/dart2js/backend_dart/sexpr_test.dart

index f1a9351d1a005c6572a34d69d1201b5c5fa0a1fb..8d297c5dcac2dd1582f76b83d0718657593c12ab 100644

--- a/tests/compiler/dart2js/backend_dart/sexpr_test.dart

+++ b/tests/compiler/dart2js/backend_dart/sexpr_test.dart

@@ -111,7 +111,8 @@ Future<List<String>> testStringifier(String code,

String withoutNullConstants = combined.replaceAll("Constant null", "");

Expect.isFalse(withoutNullConstants.contains("null"));

for (String token in expectedTokens) {

- Expect.isTrue(combined.contains(token));

+ Expect.isTrue(combined.contains(token),

+ "'$combined' doesn't contain '$token' in test:\n$code");

}

return sexprs;