Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/compiler/lib/src/resolution/send_resolver.dart

Issue 1004683002: Refactor IrBuilder to use SemanticVisitor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Handle local/static constants and index prefix/postfix. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/send_resolver.dart
diff --git a/pkg/compiler/lib/src/resolution/send_resolver.dart b/pkg/compiler/lib/src/resolution/send_resolver.dart
index 786afc2b2423e2bc72089c2cf58271a33598ac2d..aa5a747db0f6ab531631e634b1954ea03d0d272b 100644
--- a/pkg/compiler/lib/src/resolution/send_resolver.dart
+++ b/pkg/compiler/lib/src/resolution/send_resolver.dart
@@ -19,6 +19,8 @@ enum SendStructureKind {
COMPOUND_INDEX_SET,
PREFIX,
POSTFIX,
+ INDEX_PREFIX,
+ INDEX_POSTFIX,
}
abstract class SendResolverMixin {
@@ -185,7 +187,11 @@ abstract class SendResolverMixin {
kind = SendStructureKind.NOT_EQ;
break;
case BinaryOperatorKind.INDEX:
- if (node.arguments.tail.isEmpty) {
+ if (node.isPrefix) {
+ kind = SendStructureKind.INDEX_PREFIX;
+ } else if (node.isPostfix) {
+ kind = SendStructureKind.INDEX_POSTFIX;
+ } else if (node.arguments.tail.isEmpty) {
// a[b]
kind = SendStructureKind.INDEX;
} else {
@@ -215,7 +221,9 @@ abstract class SendResolverMixin {
isCompound: kind == SendStructureKind.COMPOUND ||
kind == SendStructureKind.COMPOUND_INDEX_SET ||
kind == SendStructureKind.PREFIX ||
- kind == SendStructureKind.POSTFIX);
+ kind == SendStructureKind.POSTFIX ||
+ kind == SendStructureKind.INDEX_PREFIX ||
+ kind == SendStructureKind.INDEX_POSTFIX);
if (semantics == null) {
return internalError(node, 'No semantics for $node');
}
@@ -258,6 +266,22 @@ abstract class SendResolverMixin {
assignmentOperator,
getterSelector,
selector);
+ case SendStructureKind.INDEX_PREFIX:
+ Selector getterSelector =
+ elements.getGetterSelectorInComplexSendSet(node);
+ return new IndexPrefixStructure(
+ semantics,
+ incDecOperator,
+ getterSelector,
+ selector);
+ case SendStructureKind.INDEX_POSTFIX:
+ Selector getterSelector =
+ elements.getGetterSelectorInComplexSendSet(node);
+ return new IndexPostfixStructure(
+ semantics,
+ incDecOperator,
+ getterSelector,
+ selector);
case SendStructureKind.PREFIX:
Selector getterSelector =
elements.getGetterSelectorInComplexSendSet(node);
« no previous file with comments | « pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart ('k') | pkg/compiler/lib/src/resolution/send_structure.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698