Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1004673002: [turbofan] Bring back long lost comment to AstGraphBuilder. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Bring back long lost comment to AstGraphBuilder. R=titzer@chromium.org Committed: https://crrev.com/1a37a4cc396e358e9efa20c5a9420fdf35724a38 Cr-Commit-Position: refs/heads/master@{#27162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M src/compiler/ast-graph-builder.h View 3 chunks +33 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
Very intricate change! :P
5 years, 9 months ago (2015-03-12 13:45:25 UTC) #1
titzer
LGTM, I am so sorry
5 years, 9 months ago (2015-03-12 13:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004673002/1
5 years, 9 months ago (2015-03-12 14:40:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-12 15:04:34 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-12 15:04:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a37a4cc396e358e9efa20c5a9420fdf35724a38
Cr-Commit-Position: refs/heads/master@{#27162}

Powered by Google App Engine
This is Rietveld 408576698