Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1004633002: Implement x-button for webview based signin (Closed)

Created:
5 years, 9 months ago by Dmitry Polukhin
Modified:
5 years, 9 months ago
Reviewers:
xiyuan, oshima
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement x-button for webview based signin Update assets for x-button. Added 3 states for the button: on blue background (normal), on white background (loading) and masked (modal dialog shown). Hide invisible but working by mistake x-button for normal flow. BUG=463511 TEST=manual Committed: https://crrev.com/4da1323a144eab21b1dbd287a24f254e34619be1 Cr-Commit-Position: refs/heads/master@{#320473}

Patch Set 1 #

Patch Set 2 : use custom button #

Total comments: 8

Patch Set 3 : comments resolved #

Patch Set 4 : place close button after webview in tab order #

Patch Set 5 : removed accidental changes #

Patch Set 6 : fix rtl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -19 lines) Patch
A chrome/app/theme/default_100_percent/cros/login_close_button.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/cros/login_close_button_masked.png View Binary file 0 comments Download
A chrome/app/theme/default_100_percent/cros/login_close_button_on_white.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/cros/login_close_button.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/cros/login_close_button_masked.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/cros/login_close_button_on_white.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.css View 1 2 3 4 5 1 chunk +22 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.html View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 1 2 6 chunks +27 lines, -2 lines 0 comments Download
M chrome/browser/resources/gaia_auth_host/authenticator.js View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/login/screen_container.css View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Dmitry Polukhin
PTAL
5 years, 9 months ago (2015-03-12 15:13:13 UTC) #2
xiyuan
LGTM with nits https://codereview.chromium.org/1004633002/diff/20001/chrome/browser/resources/chromeos/login/screen_gaia_signin.css File chrome/browser/resources/chromeos/login/screen_gaia_signin.css (right): https://codereview.chromium.org/1004633002/diff/20001/chrome/browser/resources/chromeos/login/screen_gaia_signin.css#newcode55 chrome/browser/resources/chromeos/login/screen_gaia_signin.css:55: display: flex; Is this needed? display:flex ...
5 years, 9 months ago (2015-03-12 18:03:42 UTC) #3
oshima
c/a/theme lgtm with one nit https://codereview.chromium.org/1004633002/diff/20001/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/1004633002/diff/20001/chrome/app/theme/theme_resources.grd#newcode442 chrome/app/theme/theme_resources.grd:442: <structure type="chrome_scaled_image" name="IDR_LOGIN_CLOSE_BUTTTON_ON_WHITE" file="cros/login_close_button_on_white.png" ...
5 years, 9 months ago (2015-03-12 18:16:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004633002/100001
5 years, 9 months ago (2015-03-13 08:47:21 UTC) #7
Dmitry Polukhin
https://codereview.chromium.org/1004633002/diff/20001/chrome/app/theme/theme_resources.grd File chrome/app/theme/theme_resources.grd (right): https://codereview.chromium.org/1004633002/diff/20001/chrome/app/theme/theme_resources.grd#newcode442 chrome/app/theme/theme_resources.grd:442: <structure type="chrome_scaled_image" name="IDR_LOGIN_CLOSE_BUTTTON_ON_WHITE" file="cros/login_close_button_on_white.png" /> On 2015/03/12 18:16:58, oshima ...
5 years, 9 months ago (2015-03-13 08:48:29 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-13 09:51:20 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-13 09:52:21 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/4da1323a144eab21b1dbd287a24f254e34619be1
Cr-Commit-Position: refs/heads/master@{#320473}

Powered by Google App Engine
This is Rietveld 408576698