Added basic completion (the commands) for gclient.

gclient_completion.sh

Index: gclient_completion.sh
diff --git a/gclient_completion.sh b/gclient_completion.sh
new file mode 100644
index 0000000000000000000000000000000000000000..2c8b5dfa338dba38dbac28a3dddcbe3df445d341
--- /dev/null
+++ b/gclient_completion.sh
@@ -0,0 +1,42 @@
+# Run from either local inclusion or /etc/bash_completions.d

[bradn, 2014/01/07 02:04:49]

So I don't have "have" on my goobuntu system.
I assume it does inside the bash_completion plumbing. This does work if I
comment out this line.
Maybe clarify how to use this without installing globally?

Overall a little more context on what this is for and how to use install it, as
bash_completion plumbing is probably not widely groked.

[Sheridan Rawlins, 2014/01/16 03:48:26]

Ok, I realize that installation into /etc/bash_completion.d is not as useful as
sourcing directly in your .bashrc so you get the latest & greatest :D

Removed this line.

Also got working on my mac (using fink to apt-get bash-completion and a newer
sed), and added comment to that effect.

On 2014/01/07 02:04:49, bradn wrote:

+declare -f have >/dev/null && have gclient || return
+
+__gclient_commands () {
+  gclient -h | grep -P '(?<=  (?:\x1b)\[32m)([\w\d]+)' -o

[bradn, 2014/01/07 02:04:49]

It looks like these terminal codes can vary depending on if the "colorama"
package is installed.
Is that handled? Why is the ESC character optional? Or has my vague recollection
of perl regexs failed me?

Also grep on osx doesn't seem to support perl style regexes.

Variants like gclient update aren't in the help list (FWIW).

[Sheridan Rawlins, 2014/01/16 01:12:59]

Added "update" manually, and used sed instead of grep - that should exist
everywhere, right?

[bradn, 2014/01/16 04:48:48]

I think so.

+}
+
+__gclient_compute_all_commands () {
+  test -n "$__gclient_all_commands" ||
+  __gclient_all_commands=$(__gclient_commands)
+}
+
+# Passthrough to git completion

[bradn, 2014/01/07 02:04:49]

Huh?

[Sheridan Rawlins, 2014/01/16 03:48:26]

Improved comment - basically just aliased so that gclient fetch did the same
thing as git fetch (if you've sourced the method (which I've also added a guard
for).

+_gclient_fetch=_git_fetch
+
+_gclient () {
+  local cur prev words cword
+  _get_comp_words_by_ref -n =: cur prev words cword
+
+  local i c=1 command
+  while [ $c -lt $cword ]; do
+    i="${words[$c]}"
+    case "$i" in
+      -*) : ignore options ;;

[bradn, 2014/01/07 02:04:49]

This hangs for me when there are flags, should that happen?

[Sheridan Rawlins, 2014/01/16 03:48:26]

Wow copied from git-completion.bash, but forgot the ((c++)) line…  Fixed.

+      *) command="$i"; break ;;
+    esac
+  done
+
+  local completion_func="_gclient_${command//-/_}"
+  local -f $completion_func >/dev/null && $completion_func && return
+
+  case "$command" in
+    ""|help)
+      if [[ "$command" != help || "$cword" -le 2 ]]; then

[bradn, 2014/01/07 02:04:49]

Maybe a comment explaining this is so gclient help ... completes?

[Sheridan Rawlins, 2014/01/16 03:48:26]

Done.

+        __gclient_compute_all_commands
+        COMPREPLY=($(compgen -W "$__gclient_all_commands" $cur))
+      fi
+      ;;
+    *) : just use the default ;;
+  esac
+} &&
+complete -F _gclient -o default gclient