Source/core/css/MediaQuery.h - Issue 100463004: Make calls to AtomicString(const String&) explicit in css/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/MediaQuery.h

Issue 100463004: Make calls to AtomicString(const String&) explicit in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Make MediaQuery::mediaType() return an AtomicString Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/MediaQuery.h

diff --git a/Source/core/css/MediaQuery.h b/Source/core/css/MediaQuery.h

index 96a7b7c2488080265b803258083a83dde32fc7da..fa5463ee7dff79b5abdc0a394c4fb28645822606 100644

--- a/Source/core/css/MediaQuery.h

+++ b/Source/core/css/MediaQuery.h

@@ -46,12 +46,12 @@ public:

Only, Not, None

};

- MediaQuery(Restrictor, const String& mediaType, PassOwnPtr<ExpressionVector> exprs);

+ MediaQuery(Restrictor, const AtomicString& mediaType, PassOwnPtr<ExpressionVector> exprs);

~MediaQuery();

Restrictor restrictor() const { return m_restrictor; }

const ExpressionVector& expressions() const { return *m_expressions; }

- String mediaType() const { return m_mediaType; }

+ const AtomicString& mediaType() const { return m_mediaType; }

Inactive 2013/12/09 19:10:59 We now use an AtomicString for the mediaType as th

bool operator==(const MediaQuery& other) const;

String cssText() const;

@@ -61,7 +61,7 @@ private:

MediaQuery(const MediaQuery&);

Restrictor m_restrictor;

- String m_mediaType;

+ AtomicString m_mediaType;

OwnPtr<ExpressionVector> m_expressions;

String m_serializationCache;

« no previous file with comments | « Source/core/css/FontFace.cpp ('k') | Source/core/css/MediaQuery.cpp » ('j') | no next file with comments »