Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Side by Side Diff: Source/core/css/resolver/StyleBuilderCustom.h

Issue 100463004: Make calls to AtomicString(const String&) explicit in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make MediaQuery::mediaType() return an AtomicString Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * * Redistributions of source code must retain the above copyright 4 * * Redistributions of source code must retain the above copyright
5 * notice, this list of conditions and the following disclaimer. 5 * notice, this list of conditions and the following disclaimer.
6 * * Redistributions in binary form must reproduce the above 6 * * Redistributions in binary form must reproduce the above
7 * copyright notice, this list of conditions and the following disclaimer 7 * copyright notice, this list of conditions and the following disclaimer
8 * in the documentation and/or other materials provided with the 8 * in the documentation and/or other materials provided with the
9 * distribution. 9 * distribution.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 ASSERT_NOT_REACHED(); 89 ASSERT_NOT_REACHED();
90 return 0; 90 return 0;
91 } 91 }
92 92
93 template <CSSValueID IdForNone> 93 template <CSSValueID IdForNone>
94 AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue* value) 94 AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue* value)
95 { 95 {
96 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value); 96 CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);
97 if (primitiveValue->getValueID() == IdForNone) 97 if (primitiveValue->getValueID() == IdForNone)
98 return nullAtom; 98 return nullAtom;
99 return primitiveValue->getStringValue(); 99 return AtomicString(primitiveValue->getStringValue());
100 } 100 }
101 101
102 } // namespace WebCore 102 } // namespace WebCore
103 103
104 #endif 104 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698