Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: Source/core/css/StyleSheetList.cpp

Issue 100463004: Make calls to AtomicString(const String&) explicit in css/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Make MediaQuery::mediaType() return an AtomicString Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /** 1 /**
2 * (C) 1999-2003 Lars Knoll (knoll@kde.org) 2 * (C) 1999-2003 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved. 3 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 { 57 {
58 return styleSheets().size(); 58 return styleSheets().size();
59 } 59 }
60 60
61 StyleSheet* StyleSheetList::item(unsigned index) 61 StyleSheet* StyleSheetList::item(unsigned index)
62 { 62 {
63 const Vector<RefPtr<StyleSheet> >& sheets = styleSheets(); 63 const Vector<RefPtr<StyleSheet> >& sheets = styleSheets();
64 return index < sheets.size() ? sheets[index].get() : 0; 64 return index < sheets.size() ? sheets[index].get() : 0;
65 } 65 }
66 66
67 HTMLStyleElement* StyleSheetList::getNamedItem(const String& name) const 67 HTMLStyleElement* StyleSheetList::getNamedItem(const AtomicString& name) const
68 { 68 {
69 if (!m_treeScope) 69 if (!m_treeScope)
70 return 0; 70 return 0;
71 71
72 // IE also supports retrieving a stylesheet by name, using the name/id of th e <style> tag 72 // IE also supports retrieving a stylesheet by name, using the name/id of th e <style> tag
73 // (this is consistent with all the other collections) 73 // (this is consistent with all the other collections)
74 // ### Bad implementation because returns a single element (are IDs always u nique?) 74 // ### Bad implementation because returns a single element (are IDs always u nique?)
75 // and doesn't look for name attribute. 75 // and doesn't look for name attribute.
76 // But unicity of stylesheet ids is good practice anyway ;) 76 // But unicity of stylesheet ids is good practice anyway ;)
77 // FIXME: We should figure out if we should change this or fix the spec. 77 // FIXME: We should figure out if we should change this or fix the spec.
78 Element* element = m_treeScope->getElementById(name); 78 Element* element = m_treeScope->getElementById(name);
79 if (element && element->hasTagName(styleTag)) 79 if (element && element->hasTagName(styleTag))
80 return toHTMLStyleElement(element); 80 return toHTMLStyleElement(element);
81 return 0; 81 return 0;
82 } 82 }
83 83
84 CSSStyleSheet* StyleSheetList::anonymousNamedGetter(const AtomicString& name) 84 CSSStyleSheet* StyleSheetList::anonymousNamedGetter(const AtomicString& name)
85 { 85 {
86 HTMLStyleElement* item = getNamedItem(name); 86 HTMLStyleElement* item = getNamedItem(name);
87 if (!item) 87 if (!item)
88 return 0; 88 return 0;
89 return item->sheet(); 89 return item->sheet();
90 } 90 }
91 91
92 } // namespace WebCore 92 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698