Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1004623009: media: Hook up ContentDecryptionModuleClient in mojo CDM service. (Closed)

Created:
5 years, 9 months ago by xhwang
Modified:
5 years, 9 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Hook up ContentDecryptionModuleClient in mojo CDM service. BUG=432998 Committed: https://crrev.com/aa0a6a43835e3f3cd4179ff01730cc9482fbe81f Cr-Commit-Position: refs/heads/master@{#321181}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M media/mojo/interfaces/content_decryption_module.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M media/mojo/interfaces/decryptor.mojom View 1 chunk +0 lines, -3 lines 0 comments Download
M media/mojo/services/mojo_cdm.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_cdm.cc View 2 chunks +4 lines, -3 lines 1 comment Download
M media/mojo/services/mojo_cdm_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_cdm_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
xhwang
PTAL https://codereview.chromium.org/1004623009/diff/1/media/mojo/services/mojo_cdm.cc File media/mojo/services/mojo_cdm.cc (right): https://codereview.chromium.org/1004623009/diff/1/media/mojo/services/mojo_cdm.cc#newcode58 media/mojo/services/mojo_cdm.cc:58: remote_cdm_->SetClient(client_ptr.Pass()); We don't need to wait for a ...
5 years, 9 months ago (2015-03-17 23:30:37 UTC) #2
DaleCurtis
lgtm
5 years, 9 months ago (2015-03-18 18:15:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1004623009/1
5 years, 9 months ago (2015-03-18 18:33:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 18:57:23 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 18:58:45 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/aa0a6a43835e3f3cd4179ff01730cc9482fbe81f
Cr-Commit-Position: refs/heads/master@{#321181}

Powered by Google App Engine
This is Rietveld 408576698